OrdinaryDiffEq.jl icon indicating copy to clipboard operation
OrdinaryDiffEq.jl copied to clipboard
verified publisher icon SciML

Fix and test allocations in Rosenbrock

Open andreasnoack opened this issue 1 month ago • 2 comments

Closes #2925 by wrapping the constant passed to ntuple in a Val

Checklist

  • [x] Appropriate tests were added
  • [x] Any code changes were done in a way that does not break public API
  • [ ] All documentation related to code changes were updated
  • [ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
  • [ ] Any new documentation only uses public API

Additional context

Add any other context about the problem here.

andreasnoack avatar Dec 10 '25 09:12 andreasnoack

The Rosenbrock tests are failing on master, see https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/20029704426/job/57435465939, so it isn't easy to assess the impact of this PR. I ran the allocation tests for Rosenbrock locally and they pass with the fix here and they don't pass withouth the fix.

andreasnoack avatar Dec 10 '25 10:12 andreasnoack

Yes, I'll need to fix up tests in this repo before merging. Some of this is JET changes with v1.12 that I'll have to dig into and that's my plan for the week. So hold up a little bit.

ChrisRackauckas avatar Dec 10 '25 11:12 ChrisRackauckas

Thanks, this won't release until I figure out the JET tests but at least the Rosenbrock tests are passing with this.

ChrisRackauckas avatar Dec 15 '25 09:12 ChrisRackauckas