SciML
Reduce number of calls in typed code
Mostly this just makes Cthulhu look prettier by cutting down the number of branches. Doesn't seem to help compile or runtime.
Co-authored-by: Yingbo Ma [email protected]
Update the failing regression test by increasing the tolerance.
Though we need to fix the buildkite to not give us ARM. I don't know who added that to the ecosystem queue but that's the most breaking thing I've seen and it probably breaks every CI using that queue, so we should get that reversed.
Though we need to fix the buildkite to not give us ARM. I don't know who added that to the ecosystem queue but that's the most breaking thing I've seen and it probably breaks every CI using that queue, so we should get that reversed.
I noticed this as well, it broke eg also TuringTutorials (and hence I assume SciMLTutorials, SciMLBenchmarks etc are broken as well). We explicitly specified the desired architecture to fix it: https://github.com/TuringLang/TuringTutorials/pull/298 Probably a good thing to do anyway, but it would have been less inconvenient if aarch64 would have been opt-in at least initially.
The error here is that ARM doesn't allow closures. We shouldn't consider that a standard architecture for CI if that's true.
The tutorials didn't even start running since one can't use bash (and probably other programs) on these machines, so I don't know if there are additional Julia-specific problems.