Optimization.jl
Optimization.jl copied to clipboard
MOI Constraint jacobian-vector fixes
Checklist
- [ ] Appropriate tests were added
- [x] Any code changes were done in a way that does not break public API
- [ ] All documentation related to code changes were updated
- [x] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
- [ ] Any new documentation only uses public API
Additional context
It seems that the methods MOI.eval_constraint_jacobian_transpose_product and MOI.eval_constraint_jacobian_product were incorrectly both evaluating the products and erroring when the evaluator possessed cons_vjp or cons_jvp functions.
Add any other context about the problem here.
FYI @baggepinnen
Can you add a test which catches this?
@aml5600 can you add the test, happy to merge it right away once that's added
@Vaibhavdixit02 sorry for the delay, please let me know if the tests are sufficient. They failed before, passed after the changes.