Optimization.jl icon indicating copy to clipboard operation
Optimization.jl copied to clipboard

Explicit warning when AD backend not specified correctly for automatic box-constraint handling with Optim

Open Vaibhavdixit02 opened this issue 9 months ago • 1 comments

Checklist

  • [ ] Appropriate tests were added
  • [ ] Any code changes were done in a way that does not break public API
  • [ ] All documentation related to code changes were updated
  • [ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
  • [ ] Any new documentation only uses public API

Additional context

Fixes #713 #558 Add any other context about the problem here.

Vaibhavdixit02 avatar May 10 '24 17:05 Vaibhavdixit02

Instead of a warning should it error?

ChrisRackauckas avatar May 12 '24 00:05 ChrisRackauckas

I guess that might lead to fewer issues, so makes sense. It would be a breaking change though

Vaibhavdixit02 avatar May 17 '24 01:05 Vaibhavdixit02

This errors with ERROR: UndefVarError: NoAD not defined in Optimization.jl v3.25.0

See issue https://github.com/SciML/Optimization.jl/issues/747

sjdaines avatar May 19 '24 11:05 sjdaines