NeuralPDE.jl icon indicating copy to clipboard operation
NeuralPDE.jl copied to clipboard

Inverse Dirichlet Adaptive Loss

Open hpieper14 opened this issue 2 years ago • 8 comments

Adds inverse dirichlet adaptive loss function to address #500

hpieper14 avatar Mar 25 '22 00:03 hpieper14

The biggest thing is that this needs tests.

ChrisRackauckas avatar Mar 25 '22 13:03 ChrisRackauckas

This seems to work ok for the 2D Poisson equation but it does not outperform the nonadaptive loss across several seeds.

hpieper14 avatar Apr 04 '22 14:04 hpieper14

Try the incompressible Navier-Stokes from the paper. I think this may only make a difference when it's "sufficiently hard", and Poisson is simple enough that non-adaptive is fine.

ChrisRackauckas avatar Apr 05 '22 12:04 ChrisRackauckas

Some of the review comments haven't been addressed, but other than that I think this is pretty close to merging. Using the Poisson 2D as the test is fine for CI, but we should test it separately on something harder. That separating testing can then turn into a tutorial.

ChrisRackauckas avatar Apr 05 '22 12:04 ChrisRackauckas

I've started working on a tutorial/test for the incompressible Navier-Stokes and I'll add the tutorial to docs/src/pinn. Should I add the test to adaptive_loss_tests.jl too?

hpieper14 avatar Apr 10 '22 23:04 hpieper14

Should I add the test to adaptive_loss_tests.jl too?

If it's not too long. That might get constrained by compute time when used in the test infrastructure.

ChrisRackauckas avatar Apr 19 '22 11:04 ChrisRackauckas

This looks really good but I don't have time until my project deadline on Tuesday to review further.

zoemcc avatar Apr 29 '22 03:04 zoemcc

This should get rebased due to changes in https://github.com/SciML/NeuralPDE.jl/pull/553. That would hopefully make it much cleaner too.

ChrisRackauckas avatar Jun 29 '22 19:06 ChrisRackauckas