ModelingToolkitStandardLibrary.jl icon indicating copy to clipboard operation
ModelingToolkitStandardLibrary.jl copied to clipboard

MTK StandardLibrary v2.7.0 broke SecondOrder-block initialization and docs

Open jaakkor2 opened this issue 10 months ago β€’ 2 comments

Describe the example

ODE initialization broke for SecondOrder block in ModelingToolkitStandardLibrary v2.7.0. Similar usage of FirstOrder-block still works.

Minimal Reproducible Example πŸ‘‡

using ModelingToolkit: t_nounits as t, ODESystem, connect, structural_simplify, @named
using OrdinaryDiffEq: ODEProblem
using ModelingToolkitStandardLibrary.Blocks: Sine, FirstOrder, SecondOrder

@named source = Sine(frequency = 1)
@named fo = FirstOrder(T = 1)
@named so = SecondOrder()
    
u0 = [
    ]

connections = [
    connect(source.output, fo.input)
    connect(source.output, so.input)
]

@named sys = ODESystem(connections, t, systems = [source, fo, so])

sys = structural_simplify(sys)
tspan = (0.0, 5.0)
par = Pair[]
prob = ODEProblem(sys, u0, tspan, par)

Error & Stacktrace ⚠️

ERROR: Initialization incomplete. Not all of the state variables of the
DAE system can be determined by the initialization. Missing
variables:

Any[soβ‚Šxd(t)]

Stacktrace:
  [1] ModelingToolkit.InitializationProblem{…}(sys::ODESystem, t::Float64, u0map::Dict{…}, parammap::Dict{…}; guesses::Dict{…}, check_length::Bool, warn_initialize_determined::Bool, kwargs::@Kwargs{})
    @ ModelingToolkit C:\Users\jaakkor2\.julia\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:1617
  [2] (ModelingToolkit.InitializationProblem{…})(::ODESystem, ::Float64, ::Vararg{…}; kwargs::@Kwargs{…})
    @ ModelingToolkit C:\Users\jaakkor2\.julia\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:1571
  [3] InitializationProblem
    @ C:\Users\jaakkor2\.julia\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:1570 [inlined]
  [4] #InitializationProblem#790
    @ C:\Users\jaakkor2\.julia\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:1559 [inlined]
  [5] InitializationProblem
    @ C:\Users\jaakkor2\.julia\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:1558 [inlined]
  [6] process_DEProblem(constructor::Type, sys::ODESystem, u0map::Vector{…}, parammap::Vector{…}; implicit_dae::Bool, du0map::Nothing, version::Nothing, tgrad::Bool, jac::Bool, checkbounds::Bool, sparse::Bool, simplify::Bool, linenumbers::Bool, parallel::Symbolics.SerialForm, eval_expression::Bool, use_union::Bool, tofloat::Bool, symbolic_u0::Bool, u0_constructor::typeof(identity), guesses::Dict{…}, t::Float64, warn_initialize_determined::Bool, build_initializeprob::Bool, kwargs::@Kwargs{…})
    @ ModelingToolkit C:\Users\jaakkor2\.julia\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:920
  [7] process_DEProblem
    @ C:\Users\jaakkor2\.julia\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:833 [inlined]
  [8] (ODEProblem{…})(sys::ODESystem, u0map::Vector{…}, tspan::Tuple{…}, parammap::Vector{…}; callback::Nothing, check_length::Bool, warn_initialize_determined::Bool, kwargs::@Kwargs{})
    @ ModelingToolkit C:\Users\jaakkor2\.julia\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:1084
  [9] (ODEProblem{…})(sys::ODESystem, u0map::Vector{…}, tspan::Tuple{…}, parammap::Vector{…})
    @ ModelingToolkit C:\Users\jaakkor2\.julia\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:1074
 [10] (ODEProblem{true})(::ODESystem, ::Vector{Any}, ::Vararg{Any}; kwargs::@Kwargs{})
    @ ModelingToolkit C:\Users\jaakkor2\.julia\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:1061
 [11] (ODEProblem{true})(::ODESystem, ::Vector{Any}, ::Vararg{Any})
    @ ModelingToolkit C:\Users\jaakkor2\.julia\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:1060
 [12] ODEProblem(::ODESystem, ::Vector{Any}, ::Vararg{Any}; kwargs::@Kwargs{})
    @ ModelingToolkit C:\Users\jaakkor2\.julia\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:1050
 [13] ODEProblem(::ODESystem, ::Vector{Any}, ::Vararg{Any})
    @ ModelingToolkit C:\Users\jaakkor2\.julia\packages\ModelingToolkit\pmsNn\src\systems\diffeqs\abstractodesystem.jl:1049
 [14] top-level scope
    @ REPL[14]:1
Some type information was truncated. Use `show(err)` to see complete types.

Not Working Environment (please complete the following information):

  • Output of using Pkg; Pkg.status()
Status `C:\temp\MTKSL27\Project.toml`
  [961ee093] ModelingToolkit v9.12.0
  [16a59e39] ModelingToolkitStandardLibrary v2.7.0
  [1dea7af3] OrdinaryDiffEq v6.74.1
  • Output of using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)
Status `C:\temp\MTKSL27\Manifest.toml`
  [47edcb42] ADTypes v0.2.7
  [1520ce14] AbstractTrees v0.4.5
  [7d9f7c33] Accessors v0.1.36
  [79e6a3ab] Adapt v4.0.4
  [ec485272] ArnoldiMethod v0.4.0
  [4fba245c] ArrayInterface v7.9.0
  [4c555306] ArrayLayouts v1.9.2
  [e2ed5e7c] Bijections v0.1.6
  [62783981] BitTwiddlingConvenienceFunctions v0.1.5
  [2a0fbf3d] CPUSummary v0.2.4
  [00ebfdb7] CSTParser v3.4.2
  [49dc2e85] Calculus v0.5.1
  [d360d2e6] ChainRulesCore v1.23.0
  [fb6a15b2] CloseOpenIntervals v0.1.12
  [861a8166] Combinatorics v1.0.2
  [a80b9123] CommonMark v0.8.12
  [38540f10] CommonSolve v0.2.4
  [bbf7d656] CommonSubexpressions v0.3.0
  [34da2185] Compat v4.14.0
  [b152e2b5] CompositeTypes v0.1.4
  [a33af91c] CompositionsBase v0.1.2
  [2569d6c7] ConcreteStructs v0.2.3
  [187b0558] ConstructionBase v1.5.5
  [adafc99b] CpuId v0.3.1
  [a8cc5b0e] Crayons v4.1.1
  [9a962f9c] DataAPI v1.16.0
  [864edb3b] DataStructures v0.18.20
  [e2d170a0] DataValueInterfaces v1.0.0
  [2b5f629d] DiffEqBase v6.149.1
  [459566f4] DiffEqCallbacks v3.6.1
  [163ba53b] DiffResults v1.1.0
  [b552c78f] DiffRules v1.15.1
  [31c24e10] Distributions v0.25.107
  [ffbed154] DocStringExtensions v0.9.3
  [5b8099bc] DomainSets v0.7.12
  [fa6b7ba4] DualNumbers v0.6.8
  [7c1d4256] DynamicPolynomials v0.5.6
  [06fc5a27] DynamicQuantities v0.13.2
  [4e289a0a] EnumX v1.0.4
βŒƒ [f151be2c] EnzymeCore v0.6.6
  [d4d017d3] ExponentialUtilities v1.26.1
  [e2ba6199] ExprTools v0.1.10
  [7034ab61] FastBroadcast v0.2.8
  [9aa1b823] FastClosures v0.3.2
  [29a986be] FastLapackInterface v2.0.2
  [1a297f60] FillArrays v1.10.0
  [64ca27bc] FindFirstFunctions v1.2.0
  [6a86dc24] FiniteDiff v2.23.1
  [1fa38f19] Format v1.3.7
  [f6369f11] ForwardDiff v0.10.36
  [069b7b12] FunctionWrappers v1.1.3
  [77dc65aa] FunctionWrappersWrappers v0.1.3
  [d9f16b24] Functors v0.4.10
  [46192b85] GPUArraysCore v0.1.6
  [c145ed77] GenericSchur v0.5.4
  [c27321d9] Glob v1.3.1
  [86223c79] Graphs v1.10.0
  [3e5b6fbb] HostCPUFeatures v0.1.16
  [34004b35] HypergeometricFunctions v0.3.23
  [615f187c] IfElse v0.1.1
  [d25df0c9] Inflate v0.1.4
  [8197267c] IntervalSets v0.7.10
  [3587e190] InverseFunctions v0.1.13
  [92d709cd] IrrationalConstants v0.2.2
  [82899510] IteratorInterfaceExtensions v1.0.0
  [692b3bcd] JLLWrappers v1.5.0
  [682c06a0] JSON v0.21.4
  [98e50ef6] JuliaFormatter v1.0.56
  [ccbc3e58] JumpProcesses v9.11.1
  [ef3ab10e] KLU v0.6.0
  [ba0b0d4f] Krylov v0.9.5
  [b964fa9f] LaTeXStrings v1.3.1
  [2ee39098] LabelledArrays v1.15.1
  [984bce1d] LambertW v0.4.6
  [23fbe1c1] Latexify v0.16.3
  [10f19ff3] LayoutPointers v0.1.15
  [5078a376] LazyArrays v1.9.1
  [d3d80556] LineSearches v7.2.0
  [7ed4a6bd] LinearSolve v2.28.0
  [2ab3a3ac] LogExpFunctions v0.3.27
  [bdcacae8] LoopVectorization v0.12.169
  [d8e11817] MLStyle v0.4.17
  [1914dd2f] MacroTools v0.5.13
  [d125e4d3] ManualMemory v0.1.8
  [a3b82374] MatrixFactorizations v2.2.0
  [bb5d69b7] MaybeInplace v0.1.2
  [e1d29d7a] Missings v1.2.0
  [961ee093] ModelingToolkit v9.12.0
  [16a59e39] ModelingToolkitStandardLibrary v2.7.0
  [46d2c3a1] MuladdMacro v0.2.4
  [102ac46a] MultivariatePolynomials v0.5.4
  [d8a4904e] MutableArithmetics v1.4.3
  [d41bc354] NLSolversBase v7.8.3
  [77ba4419] NaNMath v1.0.2
  [8913a72c] NonlinearSolve v3.10.0
  [6fe1bfb0] OffsetArrays v1.14.0
  [bac558e1] OrderedCollections v1.6.3
  [1dea7af3] OrdinaryDiffEq v6.74.1
  [90014a1f] PDMats v0.11.31
  [65ce6f38] PackageExtensionCompat v1.0.2
  [d96e819e] Parameters v0.12.3
  [69de0a69] Parsers v2.8.1
  [e409e4f3] PoissonRandom v0.4.4
  [f517fe37] Polyester v0.7.13
  [1d0040c9] PolyesterWeave v0.2.1
  [d236fae5] PreallocationTools v0.4.21
  [aea7be01] PrecompileTools v1.2.1
  [21216c6a] Preferences v1.4.3
  [1fd47b50] QuadGK v2.9.4
  [e6cf234a] RandomNumbers v1.5.3
  [3cdcf5f2] RecipesBase v1.3.4
  [731186ca] RecursiveArrayTools v3.13.0
  [f2c3362d] RecursiveFactorization v0.2.23
  [189a3867] Reexport v1.2.2
  [ae029012] Requires v1.3.0
  [79098fc4] Rmath v0.7.1
  [7e49a35a] RuntimeGeneratedFunctions v0.5.13
  [94e857df] SIMDTypes v0.1.0
  [476501e8] SLEEFPirates v0.6.42
  [0bca4576] SciMLBase v2.33.1
  [c0aeaf25] SciMLOperators v0.3.8
  [53ae85a6] SciMLStructures v1.1.0
  [efcf1570] Setfield v1.1.1
  [727e6d20] SimpleNonlinearSolve v1.7.0
  [699a6c99] SimpleTraits v0.9.4
  [ce78b400] SimpleUnPack v1.1.0
  [a2af1166] SortingAlgorithms v1.2.1
  [47a9eef4] SparseDiffTools v2.17.1
  [e56a9233] Sparspak v0.3.9
  [276daf66] SpecialFunctions v2.3.1
  [aedffcd0] Static v0.8.10
  [0d7ed370] StaticArrayInterface v1.5.0
  [90137ffa] StaticArrays v1.9.3
  [1e83bf80] StaticArraysCore v1.4.2
  [82ae8749] StatsAPI v1.7.0
  [2913bbd2] StatsBase v0.34.3
  [4c63d2b9] StatsFuns v1.3.1
  [7792a7ef] StrideArraysCore v0.5.5
  [2efcf032] SymbolicIndexingInterface v0.3.16
  [19f23fe9] SymbolicLimits v0.2.0
  [d1185830] SymbolicUtils v1.5.1
  [0c5d862f] Symbolics v5.28.0
  [3783bdb8] TableTraits v1.0.1
  [bd369af6] Tables v1.11.1
  [8290d209] ThreadingUtilities v0.5.2
  [a759f4b9] TimerOutputs v0.5.23
  [0796e94c] Tokenize v0.5.28
  [d5829a12] TriangularSolve v0.2.0
  [410a4b4d] Tricks v0.1.8
  [781d530d] TruncatedStacktraces v1.4.0
  [5c2747f8] URIs v1.5.1
  [3a884ed6] UnPack v1.0.2
  [1986cc42] Unitful v1.19.0
  [a7c27f48] Unityper v0.1.6
  [3d5dd08c] VectorizationBase v0.21.66
  [19fa3120] VertexSafeGraphs v0.2.0
  [1d5cc7b8] IntelOpenMP_jll v2024.0.2+0
  [856f044c] MKL_jll v2024.0.0+0
  [efe28fd5] OpenSpecFun_jll v0.5.5+0
  [f50d1b31] Rmath_jll v0.4.0+0
  [0dad84c5] ArgTools v1.1.1
  [56f22d72] Artifacts
  [2a0f44e3] Base64
  [ade2ca70] Dates
  [8ba89e20] Distributed
  [f43a241f] Downloads v1.6.0
  [7b1f6079] FileWatching
  [9fa8497b] Future
  [b77e0a4c] InteractiveUtils
  [4af54fe1] LazyArtifacts
  [b27032c2] LibCURL v0.6.4
  [76f85450] LibGit2
  [8f399da3] Libdl
  [37e2e46d] LinearAlgebra
  [56ddb016] Logging
  [d6f4376e] Markdown
  [a63ad114] Mmap
  [ca575930] NetworkOptions v1.2.0
  [44cfe95a] Pkg v1.10.0
  [de0858da] Printf
  [3fa0cd96] REPL
  [9a3f8284] Random
  [ea8e919c] SHA v0.7.0
  [9e88b42a] Serialization
  [1a1011a3] SharedArrays
  [6462fe0b] Sockets
  [2f01184e] SparseArrays v1.10.0
  [10745b16] Statistics v1.10.0
  [4607b0f0] SuiteSparse
  [fa267f1f] TOML v1.0.3
  [a4e569a6] Tar v1.10.0
  [8dfed614] Test
  [cf7118a7] UUIDs
  [4ec0a83e] Unicode
  [e66e0078] CompilerSupportLibraries_jll v1.1.0+0
  [deac9b47] LibCURL_jll v8.4.0+0
  [e37daf67] LibGit2_jll v1.6.4+0
  [29816b5a] LibSSH2_jll v1.11.0+1
  [c8ffd9c3] MbedTLS_jll v2.28.2+1
  [14a3606d] MozillaCACerts_jll v2023.1.10
  [4536629a] OpenBLAS_jll v0.3.23+4
  [05823500] OpenLibm_jll v0.8.1+2
  [bea87d4a] SuiteSparse_jll v7.2.1+1
  [83775a58] Zlib_jll v1.2.13+1
  [8e850b90] libblastrampoline_jll v5.8.0+1
  [8e850ede] nghttp2_jll v1.52.0+1
  [3f19e933] p7zip_jll v17.4.0+2
Info Packages marked with βŒƒ have new versions available and may be upgradable.
  • Output of versioninfo()
Julia Version 1.10.2
Commit bd47eca2c8 (2024-03-01 10:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Windows (x86_64-w64-mingw32)
  CPU: 20 Γ— 13th Gen Intel(R) Core(TM) i7-1370P
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, goldmont)
Threads: 1 default, 0 interactive, 1 GC (on 20 virtual cores)

Working Environment (please complete the following information):

  • Output of using Pkg; Pkg.status()
Status `C:\temp\MTKSL26\Project.toml`
  [961ee093] ModelingToolkit v9.12.0
βŒƒ [16a59e39] ModelingToolkitStandardLibrary v2.6.0
  [1dea7af3] OrdinaryDiffEq v6.74.1
Info Packages marked with βŒƒ have new versions available and may be upgradable.
  • Output of using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)
Status `C:\temp\MTKSL26\Manifest.toml`
  [47edcb42] ADTypes v0.2.7
  [1520ce14] AbstractTrees v0.4.5
  [7d9f7c33] Accessors v0.1.36
  [79e6a3ab] Adapt v4.0.4
  [ec485272] ArnoldiMethod v0.4.0
  [4fba245c] ArrayInterface v7.9.0
  [4c555306] ArrayLayouts v1.9.2
  [e2ed5e7c] Bijections v0.1.6
  [62783981] BitTwiddlingConvenienceFunctions v0.1.5
  [2a0fbf3d] CPUSummary v0.2.4
  [00ebfdb7] CSTParser v3.4.2
  [49dc2e85] Calculus v0.5.1
  [d360d2e6] ChainRulesCore v1.23.0
  [fb6a15b2] CloseOpenIntervals v0.1.12
  [861a8166] Combinatorics v1.0.2
  [a80b9123] CommonMark v0.8.12
  [38540f10] CommonSolve v0.2.4
  [bbf7d656] CommonSubexpressions v0.3.0
  [34da2185] Compat v4.14.0
  [b152e2b5] CompositeTypes v0.1.4
  [a33af91c] CompositionsBase v0.1.2
  [2569d6c7] ConcreteStructs v0.2.3
  [187b0558] ConstructionBase v1.5.5
  [adafc99b] CpuId v0.3.1
  [a8cc5b0e] Crayons v4.1.1
  [9a962f9c] DataAPI v1.16.0
  [864edb3b] DataStructures v0.18.20
  [e2d170a0] DataValueInterfaces v1.0.0
  [2b5f629d] DiffEqBase v6.149.1
  [459566f4] DiffEqCallbacks v3.6.1
  [163ba53b] DiffResults v1.1.0
  [b552c78f] DiffRules v1.15.1
  [31c24e10] Distributions v0.25.107
  [ffbed154] DocStringExtensions v0.9.3
  [5b8099bc] DomainSets v0.7.12
  [fa6b7ba4] DualNumbers v0.6.8
  [7c1d4256] DynamicPolynomials v0.5.6
  [06fc5a27] DynamicQuantities v0.13.2
  [4e289a0a] EnumX v1.0.4
βŒƒ [f151be2c] EnzymeCore v0.6.6
  [d4d017d3] ExponentialUtilities v1.26.1
  [e2ba6199] ExprTools v0.1.10
  [7034ab61] FastBroadcast v0.2.8
  [9aa1b823] FastClosures v0.3.2
  [29a986be] FastLapackInterface v2.0.2
  [1a297f60] FillArrays v1.10.0
  [64ca27bc] FindFirstFunctions v1.2.0
  [6a86dc24] FiniteDiff v2.23.1
  [1fa38f19] Format v1.3.7
  [f6369f11] ForwardDiff v0.10.36
  [069b7b12] FunctionWrappers v1.1.3
  [77dc65aa] FunctionWrappersWrappers v0.1.3
  [d9f16b24] Functors v0.4.10
  [46192b85] GPUArraysCore v0.1.6
  [c145ed77] GenericSchur v0.5.4
  [c27321d9] Glob v1.3.1
  [86223c79] Graphs v1.10.0
  [3e5b6fbb] HostCPUFeatures v0.1.16
  [34004b35] HypergeometricFunctions v0.3.23
  [615f187c] IfElse v0.1.1
  [d25df0c9] Inflate v0.1.4
  [8197267c] IntervalSets v0.7.10
  [3587e190] InverseFunctions v0.1.13
  [92d709cd] IrrationalConstants v0.2.2
  [82899510] IteratorInterfaceExtensions v1.0.0
  [692b3bcd] JLLWrappers v1.5.0
  [682c06a0] JSON v0.21.4
  [98e50ef6] JuliaFormatter v1.0.56
  [ccbc3e58] JumpProcesses v9.11.1
  [ef3ab10e] KLU v0.6.0
  [ba0b0d4f] Krylov v0.9.5
  [b964fa9f] LaTeXStrings v1.3.1
  [2ee39098] LabelledArrays v1.15.1
  [984bce1d] LambertW v0.4.6
  [23fbe1c1] Latexify v0.16.3
  [10f19ff3] LayoutPointers v0.1.15
  [5078a376] LazyArrays v1.9.1
  [d3d80556] LineSearches v7.2.0
  [7ed4a6bd] LinearSolve v2.28.0
  [2ab3a3ac] LogExpFunctions v0.3.27
  [bdcacae8] LoopVectorization v0.12.169
  [d8e11817] MLStyle v0.4.17
  [1914dd2f] MacroTools v0.5.13
  [d125e4d3] ManualMemory v0.1.8
  [a3b82374] MatrixFactorizations v2.2.0
  [bb5d69b7] MaybeInplace v0.1.2
  [e1d29d7a] Missings v1.2.0
  [961ee093] ModelingToolkit v9.12.0
βŒƒ [16a59e39] ModelingToolkitStandardLibrary v2.6.0
  [46d2c3a1] MuladdMacro v0.2.4
  [102ac46a] MultivariatePolynomials v0.5.4
  [d8a4904e] MutableArithmetics v1.4.3
  [d41bc354] NLSolversBase v7.8.3
  [77ba4419] NaNMath v1.0.2
  [8913a72c] NonlinearSolve v3.10.0
  [6fe1bfb0] OffsetArrays v1.14.0
  [bac558e1] OrderedCollections v1.6.3
  [1dea7af3] OrdinaryDiffEq v6.74.1
  [90014a1f] PDMats v0.11.31
  [65ce6f38] PackageExtensionCompat v1.0.2
  [d96e819e] Parameters v0.12.3
  [69de0a69] Parsers v2.8.1
  [e409e4f3] PoissonRandom v0.4.4
  [f517fe37] Polyester v0.7.13
  [1d0040c9] PolyesterWeave v0.2.1
  [d236fae5] PreallocationTools v0.4.21
  [aea7be01] PrecompileTools v1.2.1
  [21216c6a] Preferences v1.4.3
  [1fd47b50] QuadGK v2.9.4
  [e6cf234a] RandomNumbers v1.5.3
  [3cdcf5f2] RecipesBase v1.3.4
  [731186ca] RecursiveArrayTools v3.13.0
  [f2c3362d] RecursiveFactorization v0.2.23
  [189a3867] Reexport v1.2.2
  [ae029012] Requires v1.3.0
  [79098fc4] Rmath v0.7.1
  [7e49a35a] RuntimeGeneratedFunctions v0.5.13
  [94e857df] SIMDTypes v0.1.0
  [476501e8] SLEEFPirates v0.6.42
  [0bca4576] SciMLBase v2.33.1
  [c0aeaf25] SciMLOperators v0.3.8
  [53ae85a6] SciMLStructures v1.1.0
  [efcf1570] Setfield v1.1.1
  [727e6d20] SimpleNonlinearSolve v1.7.0
  [699a6c99] SimpleTraits v0.9.4
  [ce78b400] SimpleUnPack v1.1.0
  [a2af1166] SortingAlgorithms v1.2.1
  [47a9eef4] SparseDiffTools v2.17.1
  [e56a9233] Sparspak v0.3.9
  [276daf66] SpecialFunctions v2.3.1
  [aedffcd0] Static v0.8.10
  [0d7ed370] StaticArrayInterface v1.5.0
  [90137ffa] StaticArrays v1.9.3
  [1e83bf80] StaticArraysCore v1.4.2
  [82ae8749] StatsAPI v1.7.0
  [2913bbd2] StatsBase v0.34.3
  [4c63d2b9] StatsFuns v1.3.1
  [7792a7ef] StrideArraysCore v0.5.5
  [2efcf032] SymbolicIndexingInterface v0.3.16
  [19f23fe9] SymbolicLimits v0.2.0
  [d1185830] SymbolicUtils v1.5.1
  [0c5d862f] Symbolics v5.28.0
  [3783bdb8] TableTraits v1.0.1
  [bd369af6] Tables v1.11.1
  [8290d209] ThreadingUtilities v0.5.2
  [a759f4b9] TimerOutputs v0.5.23
  [0796e94c] Tokenize v0.5.28
  [d5829a12] TriangularSolve v0.2.0
  [410a4b4d] Tricks v0.1.8
  [781d530d] TruncatedStacktraces v1.4.0
  [5c2747f8] URIs v1.5.1
  [3a884ed6] UnPack v1.0.2
  [1986cc42] Unitful v1.19.0
  [a7c27f48] Unityper v0.1.6
  [3d5dd08c] VectorizationBase v0.21.66
  [19fa3120] VertexSafeGraphs v0.2.0
  [1d5cc7b8] IntelOpenMP_jll v2024.0.2+0
  [856f044c] MKL_jll v2024.0.0+0
  [efe28fd5] OpenSpecFun_jll v0.5.5+0
  [f50d1b31] Rmath_jll v0.4.0+0
  [0dad84c5] ArgTools v1.1.1
  [56f22d72] Artifacts
  [2a0f44e3] Base64
  [ade2ca70] Dates
  [8ba89e20] Distributed
  [f43a241f] Downloads v1.6.0
  [7b1f6079] FileWatching
  [9fa8497b] Future
  [b77e0a4c] InteractiveUtils
  [4af54fe1] LazyArtifacts
  [b27032c2] LibCURL v0.6.4
  [76f85450] LibGit2
  [8f399da3] Libdl
  [37e2e46d] LinearAlgebra
  [56ddb016] Logging
  [d6f4376e] Markdown
  [a63ad114] Mmap
  [ca575930] NetworkOptions v1.2.0
  [44cfe95a] Pkg v1.10.0
  [de0858da] Printf
  [3fa0cd96] REPL
  [9a3f8284] Random
  [ea8e919c] SHA v0.7.0
  [9e88b42a] Serialization
  [1a1011a3] SharedArrays
  [6462fe0b] Sockets
  [2f01184e] SparseArrays v1.10.0
  [10745b16] Statistics v1.10.0
  [4607b0f0] SuiteSparse
  [fa267f1f] TOML v1.0.3
  [a4e569a6] Tar v1.10.0
  [8dfed614] Test
  [cf7118a7] UUIDs
  [4ec0a83e] Unicode
  [e66e0078] CompilerSupportLibraries_jll v1.1.0+0
  [deac9b47] LibCURL_jll v8.4.0+0
  [e37daf67] LibGit2_jll v1.6.4+0
  [29816b5a] LibSSH2_jll v1.11.0+1
  [c8ffd9c3] MbedTLS_jll v2.28.2+1
  [14a3606d] MozillaCACerts_jll v2023.1.10
  [4536629a] OpenBLAS_jll v0.3.23+4
  [05823500] OpenLibm_jll v0.8.1+2
  [bea87d4a] SuiteSparse_jll v7.2.1+1
  [83775a58] Zlib_jll v1.2.13+1
  [8e850b90] libblastrampoline_jll v5.8.0+1
  [8e850ede] nghttp2_jll v1.52.0+1
  [3f19e933] p7zip_jll v17.4.0+2
Info Packages marked with βŒƒ have new versions available and may be upgradable.
  • Output of versioninfo()
Julia Version 1.10.2
Commit bd47eca2c8 (2024-03-01 10:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Windows (x86_64-w64-mingw32)
  CPU: 20 Γ— 13th Gen Intel(R) Core(TM) i7-1370P
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, goldmont)
Threads: 1 default, 0 interactive, 1 GC (on 20 virtual cores)

Additional context

SecondOrder is initialized with guess https://github.com/SciML/ModelingToolkitStandardLibrary.jl/blob/v2.7.0/src/Blocks/continuous.jl#L170-L173

  @variables begin
        x(t), [description = "State of SecondOrder filter", guess = 0.0]
        xd(t), [description = "Derivative state of SecondOrder filter", guess = 0.0]
    end

whereas FirstOrder is not https://github.com/SciML/ModelingToolkitStandardLibrary.jl/blob/v2.7.0/src/Blocks/continuous.jl#L125-L126

    @variables begin
        x(t) = 0.0, [description = "State of FirstOrder filter"]
    end

Seems to work with either

@named so = SecondOrder(xd = 0)

or

u0 = [
    so.xd => 0.0
    ]

jaakkor2 avatar Apr 19 '24 08:04 jaakkor2

https://github.com/SciML/ModelingToolkitStandardLibrary.jl/pull/274

This PR was breaking but was released as non-breaking

baggepinnen avatar Apr 19 '24 10:04 baggepinnen

https://docs.sciml.ai/ModelingToolkitStandardLibrary/stable/ docs still point to v.2.6.0.

Building docs is broken, here @named C = Gain(-1)

β”Œ Error: failed to run `@example` block in src\API\linear_analysis.md:93-96
β”‚ ```@example LINEAR_ANALYSIS
β”‚ matrices_L = get_looptransfer(sys, :plant_output)[1]
β”‚ L = ss(matrices_L...)
β”‚ ```
β”‚   exception =
β”‚    Initial condition underdefined. Some are missing from the variable map.
β”‚    Please provide a default (`u0`), initialization equation, or guess
β”‚    for the following variables:
β”‚
β”‚    Any[Cβ‚Šinputβ‚Šu(t)]
β”‚
β”‚    Stacktrace:
β”‚      [1] _varmap_to_vars(varmap::Dict{Any, Any}, varlist::Vector{SymbolicUtils.BasicSymbolic{Real}}; defaults::Dict{Any, Any}, check::Bool, toterm::Function, initialization_phase::Bool)
β”‚        @ ModelingToolkit C:\Users\jaakkor2\MyTemp\depot1\packages\ModelingToolkit\w72sG\src\variables.jl:205
β”‚      [2] varmap_to_vars(varmap::SciMLBase.NullParameters, varlist::Vector{SymbolicUtils.BasicSymbolic{Real}}; defaults::Dict{Any, Any}, check::Bool, toterm::Function, promotetoconcrete::Nothing, tofloat::Bool, use_union::Bool)
β”‚        @ ModelingToolkit C:\Users\jaakkor2\MyTemp\depot1\packages\ModelingToolkit\w72sG\src\variables.jl:155
β”‚      [3] get_u0_p(sys::ODESystem, u0map::Dict{Any, Any}, parammap::SciMLBase.NullParameters; use_union::Bool, tofloat::Bool, symbolic_u0::Bool)
β”‚        @ ModelingToolkit C:\Users\jaakkor2\MyTemp\depot1\packages\ModelingToolkit\w72sG\src\systems\diffeqs\abstractodesystem.jl:811
β”‚      [4] linearization_function(sys::ODESystem, inputs::Vector{Num}, outputs::Vector{Num}; simplify::Bool, initialize::Bool, op::Dict{Any, Any}, p::SciMLBase.NullParameters, zero_dummy_der::Bool, kwargs::@Kwargs{})
β”‚        @ ModelingToolkit C:\Users\jaakkor2\MyTemp\depot1\packages\ModelingToolkit\w72sG\src\systems\abstractsystem.jl:1760
β”‚      [5] get_looptransfer_function(sys::ODESystem, ap_name::Symbol; loop_openings::Nothing, kwargs::@Kwargs{op::Dict{Any, Any}, p::SciMLBase.NullParameters})
β”‚        @ ModelingToolkitStandardLibrary.Blocks C:\Users\jaakkor2\MyTemp\depot1\packages\ModelingToolkitStandardLibrary\mEg8U\src\Blocks\analysis_points.jl:348
β”‚      [6] get_looptransfer_function
β”‚        @ C:\Users\jaakkor2\MyTemp\depot1\packages\ModelingToolkitStandardLibrary\mEg8U\src\Blocks\analysis_points.jl:325 [inlined]
β”‚      [7] get_looptransfer(::ODESystem, ::Symbol; loop_openings::Nothing, op::Dict{Any, Any}, p::SciMLBase.NullParameters, kwargs::@Kwargs{})
β”‚        @ ModelingToolkitStandardLibrary.Blocks C:\Users\jaakkor2\MyTemp\depot1\packages\ModelingToolkitStandardLibrary\mEg8U\src\Blocks\analysis_points.jl:470
β”‚      [8] get_looptransfer(::ODESystem, ::Symbol)
β”‚        @ ModelingToolkitStandardLibrary.Blocks C:\Users\jaakkor2\MyTemp\depot1\packages\ModelingToolkitStandardLibrary\mEg8U\src\Blocks\analysis_points.jl:463
β”‚      [9] top-level scope
β”‚        @ linear_analysis.md:94
β”‚     [10] eval
β”‚        @ .\boot.jl:385 [inlined]
β”‚     [11] #58
β”‚        @ C:\Users\jaakkor2\MyTemp\depot1\packages\Documenter\CJeWX\src\expander_pipeline.jl:754 [inlined]
β”‚     [12] cd(f::Documenter.var"#58#60"{Module, Expr}, dir::String)
β”‚        @ Base.Filesystem .\file.jl:101
β”‚     [13] (::Documenter.var"#57#59"{Documenter.Page, Module, Expr})()
β”‚        @ Documenter C:\Users\jaakkor2\MyTemp\depot1\packages\Documenter\CJeWX\src\expander_pipeline.jl:753
β”‚     [14] (::IOCapture.var"#4#7"{DataType, Documenter.var"#57#59"{Documenter.Page, Module, Expr}, IOContext{Base.PipeEndpoint}, IOContext{Base.PipeEndpoint}, Base.TTY, Base.TTY})()
β”‚        @ IOCapture C:\Users\jaakkor2\MyTemp\depot1\packages\IOCapture\Rzdxd\src\IOCapture.jl:161
β”‚     [15] with_logstate(f::Function, logstate::Any)
β”‚        @ Base.CoreLogging .\logging.jl:515
β”‚     [16] with_logger
β”‚        @ .\logging.jl:627 [inlined]
β”‚     [17] capture(f::Documenter.var"#57#59"{Documenter.Page, Module, Expr}; rethrow::Type, color::Bool, passthrough::Bool, capture_buffer::IOBuffer)
β”‚        @ IOCapture C:\Users\jaakkor2\MyTemp\depot1\packages\IOCapture\Rzdxd\src\IOCapture.jl:158
β”‚     [18] runner(::Type{Documenter.Expanders.ExampleBlocks}, node::MarkdownAST.Node{Nothing}, page::Documenter.Page, doc::Documenter.Document)
β”‚        @ Documenter C:\Users\jaakkor2\MyTemp\depot1\packages\Documenter\CJeWX\src\expander_pipeline.jl:752
β”” @ Documenter C:\Users\jaakkor2\MyTemp\depot1\packages\Documenter\CJeWX\src\utilities\utilities.jl:44

jaakkor2 avatar May 14 '24 05:05 jaakkor2

The docs build is fixed. Yes, we reduced the number of hardcoded zero initializations a bunch. This one probably should have gotten a major, but it's far back enough now that reversing all of the other updates since then would be majorly breaking as well. So I believe this is completed, please feel free to continue the conversation if it's not.

ChrisRackauckas avatar Jul 26 '24 12:07 ChrisRackauckas