ModelingToolkit.jl icon indicating copy to clipboard operation
ModelingToolkit.jl copied to clipboard

Don't check units during initialization

Open ctessum opened this issue 1 year ago • 1 comments

...because initialization problems don't correctly handle units and units have already been checked during system initialization.

Checklist

  • [X] Appropriate tests were added
  • [X] Any code changes were done in a way that does not break public API
  • [X] All documentation related to code changes were updated
  • [X] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
  • [X] Any new documentation only uses public API

Additional context

Fixes #3086

ctessum avatar Oct 13 '24 19:10 ctessum

@AayushSabharwal can you incorporate this post your PR?

ChrisRackauckas avatar Oct 16 '24 20:10 ChrisRackauckas

@AayushSabharwal can you rebase this onto your larger change?

ChrisRackauckas avatar Oct 28 '24 08:10 ChrisRackauckas

Sure, sorry for missing this earlier.

AayushSabharwal avatar Oct 28 '24 08:10 AayushSabharwal

I have the format commit ready. Once tests pass, I'll push it and merge so we don't rerun CI unnecessarily.

AayushSabharwal avatar Oct 28 '24 09:10 AayushSabharwal

All tests pass, barring the homotopy continuation ones fixed in #3158

AayushSabharwal avatar Oct 28 '24 10:10 AayushSabharwal