ModelingToolkit.jl icon indicating copy to clipboard operation
ModelingToolkit.jl copied to clipboard

bareiss: Fix corner case assertion failure

Open Keno opened this issue 1 year ago • 3 comments

This failure was reported by @oxinabox on an equation-reordered of one of the MSL examples [1]. Essentially the bug was the we were doing a consistency check on the post-update coefficient, rather than the pre-update one. See commit message for details. There's two commits here. One to fix the actual bug and add a test and one to just improve the code slightly to remove the code pattern that led to the bug and also speed up this code slightly.

[1] https://github.com/SciML/ModelingToolkitStandardLibrary.jl/blob/main/test/Mechanical/rotational.jl#L134

Keno avatar Mar 27 '24 00:03 Keno

Bump @YingboMa.

Keno avatar Apr 24 '24 22:04 Keno

The formatter CI fails.

YingboMa avatar Apr 24 '24 23:04 YingboMa

Fixed

Keno avatar Apr 25 '24 00:04 Keno