ModelingToolkit.jl icon indicating copy to clipboard operation
ModelingToolkit.jl copied to clipboard

Test cases in examples/ do not have time dependent solutions

Open Keno opened this issue 2 years ago • 2 comments

The circuit examples in examples/ are static and do not exhibit time-dependent solutions. Ideally, future improvements to structural simplification would eliminate all equations in these models. Since they're used to test various structural simplification code, it would be good to change the examples to something e.g. with an opaque, time-varying voltage source that is not static.

Keno avatar Jun 08 '22 23:06 Keno

I think MTK already does that. And both examples in examples are ODEs and do have time dependent solutions. For instance, even though the input voltage is constant the voltage of the capacitor changes over time.

ValentinKaisermayer avatar Jun 09 '22 19:06 ValentinKaisermayer

No, that's still an autonomous equation. The issue here is that we should have some non-autonomous equations in the tests.

ChrisRackauckas avatar Jun 09 '22 21:06 ChrisRackauckas