LinearSolve.jl icon indicating copy to clipboard operation
LinearSolve.jl copied to clipboard

Perform `klu` in `init_cacheval`

Open rayegun opened this issue 1 year ago • 2 comments

Let's see if this solves our problem. It simplifies things, and reaches into internal functions less. I'll investigate UMFPACK as well, I don't remember why we're reaching so deep into that package instead of just running the factorization in init_cacheval.

rayegun avatar Jul 16 '22 17:07 rayegun

Codecov Report

Merging #158 (3342625) into main (c5168f3) will increase coverage by 0.47%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   65.66%   66.13%   +0.47%     
==========================================
  Files           9        9              
  Lines         632      629       -3     
==========================================
+ Hits          415      416       +1     
+ Misses        217      213       -4     
Impacted Files Coverage Δ
src/factorization.jl 78.84% <100.00%> (+1.59%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Jul 16 '22 17:07 codecov[bot]

Uh what's happening with codecov? There's no way these changes should do this.

rayegun avatar Jul 16 '22 17:07 rayegun