JumpProcesses.jl icon indicating copy to clipboard operation
JumpProcesses.jl copied to clipboard

Method ambiguities reported by Aqua

Open prbzrg opened this issue 1 year ago • 2 comments

In Julia v1.10, I used Aqua to detect method ambiguities in my package https://github.com/impICNF/ContinuousNormalizingFlows.jl/issues/356 and some of its report were related to this package:

Ambiguity #17
Base.Broadcast.BroadcastStyle(::JumpProcesses.ExtendedJumpArrayStyle{UStyle, JumpUStyle}, ::Style) where {UStyle, JumpUStyle, Style<:BroadcastStyle} @ JumpProcesses ~/.julia/packages/JumpProcesses/HPjOl/src/extended_jump_array.jl:139
Base.Broadcast.BroadcastStyle(::S, ::Base.Broadcast.Unknown) where S<:BroadcastStyle @ Base.Broadcast broadcast.jl:133

Possible fix, define
  Base.Broadcast.BroadcastStyle(::S, ::Base.Broadcast.Unknown) where {UStyle, JumpUStyle, S<:JumpProcesses.ExtendedJumpArrayStyle{UStyle, JumpUStyle}}


I would appreciate your attention to this issue.

prbzrg avatar Dec 27 '23 18:12 prbzrg

@ChrisRackauckas what should the suggested dispatch do? Is that a valid broadcast style combination that reuses the current corde, or should it just throw an error?

isaacsas avatar Dec 29 '23 23:12 isaacsas

I don't know. It should probably just throw an error.

ChrisRackauckas avatar Dec 29 '23 23:12 ChrisRackauckas