JumpProcesses.jl icon indicating copy to clipboard operation
JumpProcesses.jl copied to clipboard

DirectCR-RSSA

Open Vilin97 opened this issue 1 year ago • 7 comments

A new spatial SSA called DirectCRRSSA uses RSSA-style sampling to sample the site+jump. It is about 20% faster than DirectCRDirect, at least on the problem in the test/spatial/ABC.jl (5 sites in a line, 3 species, 2 reactions).

using BenchmarkTools
@btime solve(jump_problems[1], SSAStepper()) # NSM with a `CartesianGrid`, 52ms
@btime solve(jump_problems[2], SSAStepper()) # NSM with a `Graph`, 49ms
@btime solve(jump_problems[3], SSAStepper()) # DirectCRDirect with  a `CartesianGrid`, 51ms
@btime solve(jump_problems[4], SSAStepper()) # DirectCRRSSA with a `CartesianGrid`, 42ms

Vilin97 avatar Sep 11 '23 04:09 Vilin97

Pull Request Test Coverage Report for Build 6141985002

  • 172 of 181 (95.03%) changed or added relevant lines in 8 files are covered.
  • 12 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.1%) to 89.759%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/spatial/bracketing.jl 35 38 92.11%
src/spatial/rssacrdirect.jl 105 111 94.59%
<!-- Total: 172 181
Files with Coverage Reduction New Missed Lines %
src/aggregators/prioritytable.jl 1 86.86%
src/extended_jump_array.jl 1 80.52%
src/coupling.jl 2 78.18%
src/spatial/spatial_massaction_jump.jl 3 85.45%
src/spatial/directcrdirect.jl 5 87.65%
<!-- Total: 12
Totals Coverage Status
Change from base Build 6133295964: -0.1%
Covered Lines: 2419
Relevant Lines: 2695

💛 - Coveralls

github-actions[bot] avatar Sep 11 '23 05:09 github-actions[bot]

Pull Request Test Coverage Report for Build 6180696485

  • 155 of 161 (96.27%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 90.175%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/spatial/bracketing.jl 23 24 95.83%
src/spatial/directcrrssa.jl 106 111 95.5%
<!-- Total: 155 161
Totals Coverage Status
Change from base Build 6167199515: 0.3%
Covered Lines: 2423
Relevant Lines: 2687

💛 - Coveralls

coveralls avatar Sep 12 '23 04:09 coveralls

What do I need to do to get rid of the format and the spell check CI failures? @isaacsas

Vilin97 avatar Aug 21 '24 06:08 Vilin97

For spell check fix the listed spelling errors I guess. Haven’t ever used it or seen it before.

For formatting use JuliaFormatter to format the repo and add to the PR.

isaacsas avatar Aug 22 '24 17:08 isaacsas

Just FYI, I'm traveling for the next week, but will try to review once I am back in Boston.

isaacsas avatar Aug 22 '24 19:08 isaacsas