GlobalSensitivity.jl icon indicating copy to clipboard operation
GlobalSensitivity.jl copied to clipboard

Warnings because design matrices for Sobol's method are not randomized

Open devmotion opened this issue 1 year ago • 1 comments

The design matrices for Sobol's method are not randomized (https://github.com/SciML/GlobalSensitivity.jl/blob/394dc74c5290bce28a470789da93b699cac6874c/src/sobol_sensitivity.jl#L348), leading to the warning

┌ Warning: The generate_design_matrices(n, d, sampler, R = NoRand(), num_mats) method does not produces true and independent QMC matrices, see this doc warning
│ (https://docs.sciml.ai/QuasiMonteCarlo/stable/design_matrix/) for more context. Prefer using randomization methods such as R = Shift(), R = MatousekScrambling(),
│ etc., see documentation (https://docs.sciml.ai/QuasiMonteCarlo/stable/randomization/)
└ @ QuasiMonteCarlo /Users/david/.julia/packages/QuasiMonteCarlo/KvLfb/src/RandomizedQuasiMonteCarlo/iterators.jl:255

(shows up e.g. in CI: https://github.com/SciML/GlobalSensitivity.jl/actions/runs/8972149466/job/24639486952#step:6:515)

See https://docs.sciml.ai/QuasiMonteCarlo/stable/design_matrix/#DesignMatrices, https://docs.sciml.ai/QuasiMonteCarlo/stable/randomization/ and https://github.com/SciML/QuasiMonteCarlo.jl/pull/79#discussion_r1222946133.

devmotion avatar May 17 '24 22:05 devmotion

Very interesting, I hadn't seen that PR. Looks like all that needs to change here is #167

Vaibhavdixit02 avatar May 17 '24 23:05 Vaibhavdixit02