FEniCS.jl icon indicating copy to clipboard operation
FEniCS.jl copied to clipboard

Fix Precompilation

Open ysimillides opened this issue 8 years ago • 4 comments

Currently, we do not precompile the FEniCS.jl package. This is due to a known error documented here https://github.com/JuliaPy/PyCall.jl#using-pycall-from-julia-modules . The fix can be documented here https://gist.github.com/ysimillides/f7b6d01c646d1d13034ec1069eec4104 . To implement the fix though, would require refactoring of a large segment of the code base, so I will leave this until September.

ysimillides avatar Aug 16 '17 10:08 ysimillides

I was reading https://julialang.org/blog/2017/09/gsoc-fenics and see:

  1. "Fixing precompilation which would provide a large performance benefit."

My understanding, is precompilation helps only with startup (but not general use after). If I'm right, and that's not a big deal, then maybe amend the too pessimistic wording in the interesting blog post?

  1. "initial partial different equations"

typo missing -al, right.

PallHaraldsson avatar Oct 13 '17 21:10 PallHaraldsson

If I'm right, and that's not a big deal, then maybe amend the too pessimistic wording in the interesting blog post?

You are correct. It should be re-worded to say it would help speed up initial calls but that's it.

ChrisRackauckas avatar Oct 14 '17 02:10 ChrisRackauckas

Hi Pall,

Thanks for the kind words. Once theres abit more of the package implemented, I'll see about updating / creating a new blog post, hopefully with a more positive tone :)

ysimillides avatar Oct 17 '17 08:10 ysimillides

Now that precompile is the default, it might make sense to explicitly mention this in the README, otherwise people will wonder (like I did) why FEniCS.jl keeps precompiling after every startup...

clason avatar Aug 20 '18 17:08 clason