DiffEqOperators.jl icon indicating copy to clipboard operation
DiffEqOperators.jl copied to clipboard

Uninitialized field `opnorm` in JacVecOperator

Open danielwe opened this issue 2 years ago • 4 comments

opnorm is left uninitialized here:

https://github.com/SciML/DiffEqOperators.jl/blob/4b1bd632f717aee8be6f26601b37322f11f6b94a/src/jacvec_operators.jl#L24-L33

Another instance of JuliaLang/julia#24943

danielwe avatar May 16 '22 23:05 danielwe

Same issue in vecjac_operators.jl:

https://github.com/SciML/DiffEqOperators.jl/blob/4b1bd632f717aee8be6f26601b37322f11f6b94a/src/vecjac_operators.jl#L23-L32

danielwe avatar May 17 '22 05:05 danielwe

These should probably just be deprecated and deleted in favor of the ones that are more updated in SparseDiffTools.

ChrisRackauckas avatar May 20 '22 05:05 ChrisRackauckas

Are we sure that they are completely obselete? I'd prefer to leave the operators up for now until we have stencil interfaces in MOL for the high point count problems and warn of future deprecation, with links to successor packages. Do MethodOfLines and SparseDiffTools cover all use cases?

xtalax avatar May 20 '22 13:05 xtalax

Yes, these ones are not robust to alternative tags like SparseDiffTools is, so pretty much any use case should use that. There's a few things in here that aren't in there to match the AbstractSciMLOperator interface, but what we probably need to do is just make that interface package a lean package and then let SparseDiffTools extend that, add the one function, and then there's no reason for the operators here.

ChrisRackauckas avatar May 20 '22 13:05 ChrisRackauckas