DiffEqDevTools.jl icon indicating copy to clipboard operation
DiffEqDevTools.jl copied to clipboard

correct constructTanakaKasugaYamashitaYazaki6A to D and constructMikkawyEisa

Open emca1 opened this issue 4 years ago • 1 comments

Instead of

https://github.com/SciML/DiffEqDevTools.jl/blob/260b90d8634042dd3df2c194db43643fbe5162d0/src/ode_tableaus.jl#L2469

constructTanakaKasugaYamashitaYazaki6D should return

return(ExplicitRKTableau(A,c,α,6,adaptiveorder=5,αEEst=αEEst,fsal=true))


Instead of

https://github.com/SciML/DiffEqDevTools.jl/blob/260b90d8634042dd3df2c194db43643fbe5162d0/src/ode_tableaus.jl#L2554

constructTanakaKasugaYamashitaYazaki6C should return

return(ExplicitRKTableau(A,c,α,6,adaptiveorder=5,αEEst=αEEst,fsal=true))


Instead of

https://github.com/SciML/DiffEqDevTools.jl/blob/260b90d8634042dd3df2c194db43643fbe5162d0/src/ode_tableaus.jl#L2639

constructTanakaKasugaYamashitaYazaki6B should return

return(ExplicitRKTableau(A,c,α,6,adaptiveorder=5,αEEst=αEEst,fsal=true))


Instead of

https://github.com/SciML/DiffEqDevTools.jl/blob/260b90d8634042dd3df2c194db43643fbe5162d0/src/ode_tableaus.jl#L2724

constructTanakaKasugaYamashitaYazaki6A should return

return(ExplicitRKTableau(A,c,α,6,adaptiveorder=5,αEEst=αEEst,fsal=true))


Instead of

https://github.com/SciML/DiffEqDevTools.jl/blob/260b90d8634042dd3df2c194db43643fbe5162d0/src/ode_tableaus.jl#L2789

constructMikkawyEisa should return

return(ExplicitRKTableau(A,c,α,6,adaptiveorder=5,αEEst=αEEst,fsal=true))


Check the proposed orders...

emca1 avatar Jul 12 '20 12:07 emca1

Thanks for the list.

Check the proposed orders...

All of the proposed orders are checked in https://github.com/SciML/DiffEqDevTools.jl/blob/master/test/ode_tableau_convergence_tests.jl

ChrisRackauckas avatar Jul 12 '20 21:07 ChrisRackauckas