Catalyst.jl icon indicating copy to clipboard operation
Catalyst.jl copied to clipboard

Use MTK's default `t` and `D` throughout repository

Open TorkelE opened this issue 1 year ago • 2 comments

In v9, MTK creates default time and differential variables. This PRs make Catalyst use these (throughout tests and documentation). I.e. instead of

@variables t
D = Differential(t)

we now do

import Catalyst: t_nounits as t, D_nounits as D

CI still cannot work due to all_dimensionless issue mentioned in https://github.com/SciML/Catalyst.jl/pull/785 (which this one depends on).

TorkelE avatar Feb 13 '24 16:02 TorkelE

Can you change the base branch for all these PRs you are opening to v14 so they are readable?

isaacsas avatar Feb 13 '24 16:02 isaacsas

The other ones are to the v14 branch already, changed this one as well now. This one is based on https://github.com/SciML/Catalyst.jl/pull/785 (because Catalyst cannot, currently, compile on ModelingToolkit#master without that one)

TorkelE avatar Feb 13 '24 16:02 TorkelE

The rebase must have messed up, I will try to figure out and fix.

TorkelE avatar Mar 18 '24 18:03 TorkelE