Catalyst.jl icon indicating copy to clipboard operation
Catalyst.jl copied to clipboard

Improve documentation of `remove_conserved` when creating an `ODESystem` - and make it default to `true`?

Open ranocha opened this issue 1 year ago • 4 comments

We have just discussed this on Slack. See https://docs.sciml.ai/Catalyst/stable/faqs/#How-to-index-solution-objects-using-symbolic-variables-and-observables?

ranocha avatar Jan 26 '24 12:01 ranocha

Yeah, somehow we never got this more at the fore-front as a feature even though it is in the docs in several places:

https://docs.sciml.ai/Catalyst/stable/catalyst_applications/homotopy_continuation/#Systems-with-conservation-laws

https://docs.sciml.ai/Catalyst/stable/faqs/#How-to-index-solution-objects-using-symbolic-variables-and-observables?

isaacsas avatar Jan 26 '24 13:01 isaacsas

@TorkelE what do you think about defaulting it to true? I know we've discussed but I can't remember if you had a reason not to do it by default for ODEs?

isaacsas avatar May 13 '24 16:05 isaacsas

I don't see a reason to not make it true. Enforcing conservation generally makes the numerics more stable, and structural simplify should then eliminate the equations anyways so we'd get smaller simpler equations to solve.

ChrisRackauckas avatar May 13 '24 19:05 ChrisRackauckas

OK, we can go with it always being true for ODE models.

isaacsas avatar May 13 '24 20:05 isaacsas