Catalyst.jl icon indicating copy to clipboard operation
Catalyst.jl copied to clipboard

CompatHelper: bump compat for BifurcationKit in [weakdeps] to 0.4, (keep existing compat)

Open github-actions[bot] opened this issue 1 year ago • 1 comments

This pull request changes the compat entry for the BifurcationKit package from 0.3 to 0.3, 0.4. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

github-actions[bot] avatar Aug 21 '24 00:08 github-actions[bot]

This needs MTK to update to BifurcationKit .4 first

isaacsas avatar Sep 21 '24 19:09 isaacsas

@TorkelE could you update the BifurcationKit extension now? MTK has updated to the newest version and dropped support for the version we have, giving us some issues (for example, we can't use the latest MTK anymore in our docs, and I guess maybe in our tests).

isaacsas avatar Oct 26 '24 12:10 isaacsas

It's a breaking change too so supporting both is a bit hard, but we can have versioned @static if statements if it helps.

ChrisRackauckas avatar Oct 26 '24 18:10 ChrisRackauckas

Only supporting 0.4 is fine; that wasn’t meant to be a complaint. We just need to update our wrapper around the MTK extension, and maybe the doc examples if the usage has changed. Since the next Catalyst is breaking it seems fine to drop v3 versions.

isaacsas avatar Oct 26 '24 19:10 isaacsas