scikit-surgeryvtk icon indicating copy to clipboard operation
scikit-surgeryvtk copied to clipboard

Class hierarchy is a bit messy for few visualization pipelines

Open mxochicale opened this issue 1 year ago • 0 comments

For the record, the following list of classes inherent Qt objects that might create issues with data pipelines (e.g. https://github.com/SciKit-Surgery/scikit-surgeryvtk/issues/202), also I don't see any logic in the class hierarchy but different users prototyping their own pipelines.

class VTKOverlayWindow(QVTKRenderWindowInteractor)
class VTKRenderingGenerator(QtWidgets.QWidget)
class VTKStereoInterlacedWindow(QtWidgets.QWidget)
class VTKLUSSimulator(rg.VTKRenderingGenerator)

Hence, if we would like to fix the above, I would suggest the following steps:

  • Follow good practices for pipelines, these are few examples:
    • MITK: https://docs.mitk.org/nightly/PipelineingConceptPage.html
    • VisGUI: https://www.kitware.com/visgui-a-visualization-framework-for-video-analysis/
  • Refactor classes and unit tests for multi-OSs (prototype and run unit tests in ubuntu-latest OS)
  • Add examples in tutorials

mxochicale avatar Mar 02 '23 10:03 mxochicale