scikit-surgeryvtk

scikit-surgeryvtk copied to clipboard

I ran into several problems when integrating the outline renderer into SmartLiver, and had to abandon it. So, it could do with a bit of work. * Firstly, it appears...

MattClarkson

> Hello, Previously, manually configured webhooks from integrations did not have a secret attached to them. In order to improve security, we have deployed an update so that all new...

mxochicale

Add index output to project_facing_points

2

In GitLab by @JoaoDanielMarquesRamalhinho on Feb 11, 2019, 09:54 * In sksurgeryvtk/utils/projection_utils.py, the function project_facing_points does not output the index of the 3D points that face the camera. * In...

thompson318

Suppress errors when we make a base model with no data

12

In GitLab by @StephenThompson on Jan 16, 2020, 16:24

thompson318

Logic to face vtkCamera at an image should be refactored, and generalised to arbitrary image planes.

2

In GitLab by @MattClarkson on Feb 5, 2019, 20:43 In vtk_overlay_widget there is logic in __update_video_image_camera. This positions the camera to face an image, but assumes the x and y...

thompson318

Add unit test to examine if we can use VTKOverlayWindow to match SmartLiver/surface_plus_probe.py

1

Nina needs to be able to programmatically (i.e. in a simulator) render something given a set of intrinsics, that matches what is seen in SmartLiver/surface_plus_probe.py

MattClarkson

For the record, the following list of classes inherent Qt objects that might create issues with data pipelines (e.g. https://github.com/SciKit-Surgery/scikit-surgeryvtk/issues/202), also I don't see any logic in the class hierarchy...

mxochicale

Outdated https://github.com/SciKit-Surgery/scikit-surgeryvtk/blob/master/docs/tutorials/overlay_window.ipynb which seems to use `sksurgeryutils.common_overlay_app` which might be a replication of https://github.com/SciKit-Surgery/scikit-surgeryvtk/blob/master/sksurgeryvtk/widgets/vtk_overlay_window.py ``` import sksurgeryutils.common_overlay_apps as coa from PySide2 import QtWidgets, QtCore ``` * [x] So, will remove...

mxochicale

Duplicate logic in surface_model_loader.py and vtk_surface_model_directory_loader.py

1

Both these classes have logic to parse dictionary keys. To me it looks duplcated and yet slightly different. Check and remove duplication if possible.

thompson318