scikit-surgery icon indicating copy to clipboard operation
scikit-surgery copied to clipboard

Breaking changes to utils and calibration

Open tdowrick opened this issue 2 years ago • 1 comments

Hi both,

There’s some breaking changes coming to scikit-surgeryutils.

OpenCV-Headless

Due to changing to opencv-headless, this means that scikit-surgeryimage, vtk, calibration etc. cannot have opencv GUIs in them. So, the video calibration apps had to move out of scikit-surgerycalibration into scikit-surgeryutils. 

Libraries that are now on opencv-headless.

scikit-surgeryimage>=0.10.1
scikit-surgeryvtk>=1.0.6
scikit-surgerycalibration>=0.2.1

(which was enough for SmartLiver incidentally)

scikit-surgeryarucotracker>=0.2.7

and I’m doing scikit-surgeryutils

Further along, this means that scikit-surgerybard will need doing before the summer school in July, and should call utilities in scikit-surgeryutils. Same argument probably for MPHY0026 in due course.

Widget API changes

Also, in scikit-surgeryutils, this meant that I had to use PySide2 for the video calibration apps, and some refactoring. The OverlayBaseApp should really be a widget, so that it can be embedded in layouts. So, I made it a widget. This means the update() method, called by the QTimer had to change to update_view(). 

So, these will have knock on effects to snappysonix, and various demo apps and tutorials. 

Now, as it happened, I made these widget changes, while trying to address the first issue, but ended up making a separate widget for the video apps. So, I could roll them back. But I don’t think its worth it, as we should move forward.

Any thoughts? Or anything I’ve forgotten?

M

tdowrick avatar May 30 '22 10:05 tdowrick