memilio
memilio copied to clipboard
978 Behavior model secirvvs based on ICU occupancy
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
- [ ] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
- [ ] New code adheres to coding guidelines
- [ ] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
- [ ] Tests are added for new functionality and a local test run was successful (with and without OpenMP)
- [ ] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
- [ ] Proper attention to licenses, especially no new third-party software with conflicting license has been added
- [ ] (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.
Checks by code reviewer(s)
- [ ] Corresponding issue(s) is/are linked and addressed
- [ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
- [ ] Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
- [ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
- [ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.35%. Comparing base (
ce75c58
) to head (b5c2805
). Report is 20 commits behind head on main.
:exclamation: Current head b5c2805 differs from pull request most recent head d3e9d28. Consider uploading reports for the commit d3e9d28 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #986 +/- ##
==========================================
- Coverage 96.36% 96.35% -0.01%
==========================================
Files 123 129 +6
Lines 9844 10106 +262
==========================================
+ Hits 9486 9738 +252
- Misses 358 368 +10
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.