memilio icon indicating copy to clipboard operation
memilio copied to clipboard

444 add clustering methods for npi data

Open mknaranja opened this issue 1 year ago • 1 comments

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

  • Add clustering for NPI data set

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • [ ] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • [ ] New code adheres to coding guidelines
  • [ ] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • [ ] Tests are added for new functionality and a local test run was successful
  • [ ] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • [ ] Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • [ ] (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • [ ] Corresponding issue(s) is/are linked and addressed
  • [ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • [ ] Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • [ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Closes #444

mknaranja avatar Jan 05 '24 14:01 mknaranja

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.34%. Comparing base (8ddb863) to head (d3d1d5c). Report is 27 commits behind head on main.

:exclamation: Current head d3d1d5c differs from pull request most recent head 3eaf31c

Please upload reports for the commit 3eaf31c to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #883   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         129      129           
  Lines       10056    10056           
=======================================
  Hits         9688     9688           
  Misses        368      368           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 28 '24 15:03 codecov[bot]