frontend icon indicating copy to clipboard operation
frontend copied to clipboard

feat: replace samples table with the new dynamic material table

Open martin-trajanovski opened this issue 8 months ago • 1 comments

Description

Short description of the pull request

Motivation

Background on use case, changes needed

Fixes:

Please provide a list of the fixes implemented in this PR

  • Items added

Changes:

Please provide a list of the changes implemented by this PR

  • changes made

Tests included

  • [ ] Included for each change/fix?
  • [ ] Passing? (Merge will not be approved unless this is checked)

Documentation

  • [ ] swagger documentation updated [required]
  • [ ] official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • [ ] Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Replace samples and instruments tables with a new dynamic material table component, improving table functionality and user experience

New Features:

  • Introduced a dynamic material table component with enhanced features like server-side pagination, sorting, and table settings customization

Enhancements:

  • Refactored table implementations in samples and instruments dashboards to use a more flexible and configurable table component
  • Improved table interaction with more robust event handling
  • Added support for saving and restoring table settings

Chores:

  • Updated state management and selectors to support new table functionality
  • Removed deprecated page and sort change actions

martin-trajanovski avatar Apr 07 '25 14:04 martin-trajanovski

:tada: Snyk checks have passed. No issues have been found so far.

:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)

henrikjohansson712 avatar May 19 '25 20:05 henrikjohansson712

One UI issue I found, when I try to save table settings, I need to open the settings two times.

  1. Open table settings select columns and click check icon, which closes the dropdown.
  2. Re-open table settings and click Save table settings button to save.

Or maybe it's not an issue? but it's kinda confusing behavior to me

Junjiequan avatar May 26 '25 12:05 Junjiequan

One UI issue I found, when I try to save table settings, I need to open the settings two times.

  1. Open table settings select columns and click check icon, which closes the dropdown.
  2. Re-open table settings and click Save table settings button to save.

Or maybe it's not an issue? but it's kinda confusing behavior to me

@Junjiequan you are right this requires one more extra click but I think that is the normal table behavior since the beginning when we introduced it. I guess we can fix this at some point with some other UI improvements as it is not a critical issue/bug .

martin-trajanovski avatar May 26 '25 12:05 martin-trajanovski