Merge ILL branch
Description
This is a fork version of SciCat implementing various features or changes to fit ILL wishes
Motivation
ILL wanted a number of changes and adaptations to SciCat and wanted me to produce a first prototype of what they would like SciCat to have
Fixes:
Please provide a list of the fixes implemented in this PR
- OutputDatasetObsoleteDto seemed to not be fully replaced by OuputDatasetDto so I've added an overload to it to make dataset having the possibility to have multiple instruments
Changes:
Some changes are specific to ILL
- add of NomadLogs and NomadCharts buttons in the app header if we are in the dataset details page, will probably move them in LogBook tab in a future version
- big rework of dataset details page:
- merge of General information and Creator information into a new Dataset information box
- implementation of an instrument box containing information about instruments properties during the acquisition
- implementation of a DatasetOverview block, as we have decided that a dataset corresponds to a sample of a dataset, we have added a box that contains information about each file that compound the dataset (File name, sample type, sample subtype, duration of the acquisition)
- implementation of a sample environment block
- implementation of a sample properties block
- rework of dataset table page:
- implementation of instrument column, sorting is not correctly implemented yet because it lack of an api endpoint to sort by instrument name
- implementation of number of files column to know how many files compose a dataset
- add of filtering by instrument
- add of search service used in the new block dataset overview of the page dataset details
- change of breadcrumb for instrument page to show instrument name instead of ID
The filtering on instrument requires a backend change that I've made.
I know that those changes are breaking and not properly done to be merged into core currently. The objective is mainly to open discussions with SciCat to work together on a proper implementation of those changes into core, especially that some changes implies architectures modifications.
Ah, sorry I didn't notice it's just a suggestion code, please ignore my previous review comments
We are closing this PR as it was just a proof-of-concept and @MatthMig started to break it down in smaller PRs. As soon as ILL has a person work on SciCat, we will work with them to bring some of the changes introduced by this PR in to master, but in smaller PRs.