github-profile-achievements icon indicating copy to clipboard operation
github-profile-achievements copied to clipboard

Update `YOLO` description to be more specific

Open sgrokym opened this issue 2 years ago • 9 comments

sgrokym avatar Sep 29 '22 04:09 sgrokym

Thank you for the PR, but have you done any testing around this? Because at least in the past this wasn't necessary, since for example my unlock doesn't fulfill said criteria: https://github.com/Schweinepriester?achievement=yolo&tab=achievements

Schweinepriester avatar Sep 30 '22 13:09 Schweinepriester

Is it possible that this should be "merge without a review, but with a pending review request"? I have definitely merged a lot of PRs on my own repositories, but the one that made me get the badge was https://github.com/babel/minify/pull/1034

nicolo-ribaudo avatar Sep 30 '22 13:09 nicolo-ribaudo

"merge without a review, but with a pending review request"

exactly this is my current status (proposed here and then verified with the PR which unlocked it for me).

but we know for sure they tinkered after the release, so…

Schweinepriester avatar Sep 30 '22 13:09 Schweinepriester

OK, let me change the sentence a bit. How about this one. Merged a reviewable pull request without code review

In my experience the following did not work. https://github.com/sgrokym/adr-jan/pull/1 So, I think Merged a reviewable pull request without code review is more appropriate than Merged a pull request without code review

FYI, I don't have YOLO badge so I can test which one does not work.

sgrokym avatar Oct 01 '22 07:10 sgrokym

Pls. make the YOLO Description more specific because I don't get this achievement

FleetAdmiralJakob avatar Nov 07 '22 19:11 FleetAdmiralJakob

good

Lymengchun avatar Nov 14 '22 06:11 Lymengchun

Quick update on the experiment YOLO PR #1. We confirmed that the guide how to earn YOLO badge is working.

As described there all you need is ~~love~~ follow the steps:

  1. Create any PR on any repository
  2. Assign another person as a reviewer. If you don't have any, invite somebody to collaborate.
  3. Accept the warning and merge the PR without review
  4. Celebrate your new profile badge.

Let me know if you have any questions.

ParanoidUser avatar Jan 31 '23 14:01 ParanoidUser

resolve conflict ?

marcos-jesus avatar Feb 07 '23 16:02 marcos-jesus

@ParanoidUser It's good!

marcos-jesus avatar Feb 07 '23 16:02 marcos-jesus