github-profile-achievements
github-profile-achievements copied to clipboard
Update `YOLO` description to be more specific
Thank you for the PR, but have you done any testing around this? Because at least in the past this wasn't necessary, since for example my unlock doesn't fulfill said criteria: https://github.com/Schweinepriester?achievement=yolo&tab=achievements
Is it possible that this should be "merge without a review, but with a pending review request"? I have definitely merged a lot of PRs on my own repositories, but the one that made me get the badge was https://github.com/babel/minify/pull/1034
"merge without a review, but with a pending review request"
exactly this is my current status (proposed here and then verified with the PR which unlocked it for me).
but we know for sure they tinkered after the release, so…
OK, let me change the sentence a bit.
How about this one.
Merged a reviewable pull request without code review
In my experience the following did not work.
https://github.com/sgrokym/adr-jan/pull/1
So, I think Merged a reviewable pull request without code review
is more appropriate than Merged a pull request without code review
FYI, I don't have YOLO badge so I can test which one does not work.
Pls. make the YOLO Description more specific because I don't get this achievement
good
Quick update on the experiment YOLO PR #1. We confirmed that the guide how to earn YOLO badge is working.
As described there all you need is ~~love~~ follow the steps:
- Create any PR on any repository
- Assign another person as a reviewer. If you don't have any, invite somebody to collaborate.
- Accept the warning and merge the PR without review
- Celebrate your new profile badge.
Let me know if you have any questions.
resolve conflict ?
@ParanoidUser It's good!