github-profile-achievements icon indicating copy to clipboard operation
github-profile-achievements copied to clipboard

Published 20 hours ago • verified publisher icon Schweinepriester

Add CI to build SVGs with images embedded

Open Rongronggg9 opened this issue 2 years ago • 7 comments

It should help fix the "CORS" (actually CSP, not CORS) issue mentioned in https://github.com/Schweinepriester/github-profile-achievements/issues/30#issuecomment-1159577516.

Preview: https://github.com/Rongronggg9/github-profile-achievements/tree/dist

It is believed to be the only solution to work around the CSP issue since it is chosen by opencollective to render user avatars in contributor tables.

Rongronggg9 avatar Jun 19 '22 01:06 Rongronggg9

Thank you for the PR and the inspiration! But it will probably some time before I merge this if at all, because the proper SVGs (not the test ones) will take quiet a bit of hand massaging to make them nice. Because of this so far I had thought about doing the base64 conversion "manually" or maybe linking to the images in this repo (unlikely). But maybe I'll do an intermediate step and having an action like this do the last one… we'll see!

Schweinepriester avatar Jun 19 '22 09:06 Schweinepriester

Sure. Looking forward to the finished SVGs. The current "testing" ones are already impressive for me :)

Rongronggg9 avatar Jun 19 '22 12:06 Rongronggg9

What do you think about merging?

climax1115 avatar Jul 11 '22 08:07 climax1115

good

Lymengchun avatar Nov 14 '22 06:11 Lymengchun

need help>

camerondevuk avatar Nov 24 '22 10:11 camerondevuk

@Schweinepriester Any chance to remove and block some of these messages and users? :smiling_face_with_tear:

akirataguchi115 avatar Nov 24 '22 10:11 akirataguchi115

O que está havendo ?

CHARLLYS97 avatar Dec 27 '22 15:12 CHARLLYS97