KiBoM icon indicating copy to clipboard operation
KiBoM copied to clipboard

No grouping side effect

Open set-soft opened this issue 4 years ago • 0 comments

I'm not sure about the following behavior:

https://github.com/SchrodingersGat/KiBoM/blob/06a14866d8166cfa71ae8ac1a48bda0c160fb380/kibom/component.py#L120-L121

This disables the grouping mechanism, this is OK. But the side effect is that multi-part components will be repeated (as many times as sub-parts). I this the code should be:

if len(self.prefs.groups) == 0: 
    return self.getRef() == other.getRef()

So we don't get the same ref multiple times.

set-soft avatar Aug 12 '20 12:08 set-soft