fnm icon indicating copy to clipboard operation
fnm copied to clipboard

WIP: Fix 'fnm default system' not working

Open juliankrieger opened this issue 4 years ago • 7 comments

This fixes the issue mentioned in #336, namely

➜  ~ fnm --version
fnm 1.22.8
➜  ~ fnm default system
error: Can't create symlink for alias: entity not found
➜  ~

@Schniz, I could only test this locally on my machine and it seems to be working. I'm also not sure if tests are running correctly, since most of them fail weirdly, even when ran on the most recent master branch.

juliankrieger avatar Jan 16 '21 22:01 juliankrieger

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/schniz/fnm/8h3zynd6r
✅ Preview: https://fnm-git-fork-juliankrieger-master.schniz.vercel.app

vercel[bot] avatar Jan 16 '21 22:01 vercel[bot]

I think you're correct on this one. Aliasing to the system version is not supported and that's correct, however I kind of expect fnm default system to set the current node version to system without printing an error message

I think catching the error and handling it higher up the chain is a good solution for now (at least until aliasing to the system version is supported)

juliankrieger avatar Jan 17 '21 11:01 juliankrieger

however I kind of expect fnm default system to set the current node version to system without printing an error message

But, this PR does not do that. Right? So it's not fixing fnm default system, It's an aesthetic change for better error messages which I like. Can you please update the PR so it would be as I mentioned before? When we have time, we can actually fix the issue. But we can start with better error for now 😄

Schniz avatar Jan 21 '21 16:01 Schniz

however I kind of expect fnm default system to set the current node version to system without printing an error message

But, this PR does not do that. Right? So it's not fixing fnm default system, It's an aesthetic change for better error messages which I like. Can you please update the PR so it would be as I mentioned before? When we have time, we can actually fix the issue. But we can start with better error for now 😄

Yes, I'll see if I find time this weekend

juliankrieger avatar Jan 22 '21 15:01 juliankrieger

No pressure 😇 have a great weekend

Schniz avatar Jan 22 '21 16:01 Schniz

@juliankrieger still working on this?

romgrk avatar Mar 06 '21 03:03 romgrk

So strange, on M1 it works fine but on Intel machines seems not work EDIT: On M1 too not working, i don't know why and how

dalisoft avatar Sep 18 '21 11:09 dalisoft