fnm icon indicating copy to clipboard operation
fnm copied to clipboard

fix: set correct INSTALL_DIR for brew installation

Open zeroberry opened this issue 11 months ago • 5 comments

fixes #824, #1190, #1194, #1237, #1279

On macOS, when you install fnm using Homebrew, the installation directory ends up being something like /usr/local/opt/fnm or /opt/homebrew/opt/fnm instead of $HOME/.fnm, $XDG_DATA_HOME/fnm, $HOME/Library/Application Support/fnm.

I updated INSTALL_DIR to match the correct location for Homebrew installations. Also, since Homebrew takes care of the PATH automatically, export PATH step is removed.

zeroberry avatar Jan 08 '25 15:01 zeroberry

⚠️ No Changeset found

Latest commit: 924078dcea302b126e214eedbebcd9416158a7a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 08 '25 15:01 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 3:13pm

vercel[bot] avatar Jan 08 '25 15:01 vercel[bot]

<3 I've literally just sorted this out in my own system when the readme instructions didn't work.

ericbdev avatar Jan 08 '25 15:01 ericbdev

If you just install using brew install fnm (which the install script is doing) no additional config is required other then adding something like

eval "$(fnm env --use-on-cd --version-file-strategy=recursive)"

to your .zshrc

as brew automatically adds

eval "$(/opt/homebrew/bin/brew shellenv)"

to your .zprofile which adds /opt/homebrew/bin to your path. and by installing fnm, brew adds a symlink to the correct binary already

kaaax0815 avatar Jan 09 '25 09:01 kaaax0815

👋 @Schniz looks like this PR and https://github.com/Schniz/fnm/pull/1414 both attempt to fix this issue, do you think one of them could be merged soon? Fresh installs following the instructions at https://nodejs.org/en/download still seem to fail on MacOS due to these bugs.

polybuildr avatar Apr 27 '25 08:04 polybuildr

:lfgtm: thank you

Schniz avatar Jul 20 '25 07:07 Schniz