fnm icon indicating copy to clipboard operation
fnm copied to clipboard

Add progress bar to install command

Open eblocha opened this issue 1 year ago • 3 comments

This adds the feature requested in #949. Doesn't display if the response from the download mirror doesn't have a content-length header.

I hard-coded a bar template, looks like this:

image

I think we could add an env var to customize this, but we'd need to handle syntax errors gracefully (show warning, maybe?).

Added a --no-progress option to turn this off. It writes to stderr.

eblocha avatar Aug 19 '23 17:08 eblocha

🦋 Changeset detected

Latest commit: 065ff494766b40a8a92f0449ff3bd699a95fb96d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 19 '23 17:08 changeset-bot[bot]

is there a way to test a progress bar? :thonk:

Schniz avatar Aug 21 '23 07:08 Schniz

Looks like there are some failing e2e tests, saying "operation timed out" when trying to hit the proxy. Any ideas what's going on there? Some kind of rate limiting from the nodejs servers?

eblocha avatar Aug 22 '23 01:08 eblocha

I'll merge this and add some fixes, thank you so much for this contribution and sorry I haven't merged it till now :meow_pensive-pray:

Schniz avatar May 25 '24 17:05 Schniz

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 5:03pm

vercel[bot] avatar May 25 '24 17:05 vercel[bot]