Gal Schlezinger

Results 295 comments of Gal Schlezinger

It happens to me too, but without any "exit", just by making a process send a message to another process: ```reason open Reactor.System; Reactor.Node.(Policy.default() |> setup); let printer = spawn((ctx,...

It also looks like there is some kind of race condition here. I'm just running the following code: ```reason Fmt_tty.setup_std_outputs(); Logs.set_level(Some(Logs.Debug)); Logs.set_reporter(Logs_fmt.reporter()); open Reactor.System; Reactor.Node.(Policy.default() |> setup); let _ =...

Maybe that's related to `Process.kill`? https://github.com/ostera/reactor/blob/9f3f7486e142150828ff20e1ec79e367dbaa8adb/src/platform/process.re#L65 I guess that sending a `sigkill` doesn't wait for the result (which is killing). Maybe we should wait for that?

this could be solved if I create my zip on my own, without using the GitHub generated zip from the artifact, and upload it directly to the release drafts. [See...

Right now I am publishing manually by downloading the artifacts. These artifacts are being uploaded with `actions/upload-artifact` (I am uploading a single file each time) and when they're being downloaded,...

ah and by the way, thanks for stepping up and making a PR. I really appreciate your contribution. It's not something I take for granted :pray:

re: `to_clap_shell`: * it's currently not returning `Option` but I think we should do that, in the meantime we can panic like we do in WinCmd: https://github.com/Schniz/fnm/blob/c85ff97f1404b0042f7378acb0ad67b3fd607189/src/shell/windows_cmd/mod.rs#L8-L11 * we can...

> my decision making was mainly driven by my lack of experience with rust I built fnm in Rust when I had zero experience in Rust, I want to refactor...

I think this was asked before. so might be a duplicate. anyway, in the meantime you can use `fnm install --lts`.

thought: maybe `fnm env --shell=nu` can only print to stdout a file in the temp directory it already created? 😁 then it will be `source "$(fnm env --shell=nu)"` or something...