CSS-Filters-Polyfill icon indicating copy to clipboard operation
CSS-Filters-Polyfill copied to clipboard

Global variables

Open sp00n opened this issue 11 years ago • 0 comments

You have a few variables in your files that pollute the global namespace: currentproperties, idx, key, mozFilter, msFilter, oFilter and webkitFilter all show up in the global DOM list.

Also, the cssParser.js file you're using uses A LOT of global variables for its internal logic, which seems kind of superflous. I haven't done any extensive testing (besides Firefox and Chrome), but I've simply put everything except the CSSScanner and CSSParser functions inside a self-executing anonymous function, and it seems to work for the time being (see above). There are certainly better ways though. Maybe even some revised libraries for this, but I couldn't find the original code with a quick search for "cssparser js mozilla".

sp00n avatar Jul 08 '14 12:07 sp00n