Erik Schamper
Erik Schamper
> Ideally though, skipping RegBack could be enabled at the keys method. I think a better approach is for it to be user toggle-able somehow. Maybe through an environment variable...
I think ideally there's a common way we can set flags on a `Target` object (i.e. `Target.props`), and every CLI tool just uses that (like we already have common argument...
I'd rather not switch back to PyYAML. I see in the README of ruamel.yaml that they'll also remove the allowing of duplicate keys completely in the next release... Is there...
@respondersGY if you do work on this, can you please not fix it in the `network_managers.py` implementation, but rather convert it to the new `NetworkPlugin` interface?
`network_manager.py` and any and all references or calls into it will be completely removed in a future release. Everything will have to be implemented as a `NetworkPlugin`.
@OlafHaalstra can you provide a full stacktrace (ideally from the log file since it includes debug logging) from acquire?
It's likely something related to https://github.com/fox-it/acquire/pull/203 that we missed with that PR. What version of acquire did you encounter this with, the latest I assume?
This is likely because of the wrong order of processing the module arguments here: https://github.com/fox-it/acquire/blob/2c0092bc8fd064d7f50ae6618e2166967fd8b839/acquire/acquire.py#L1764-L1784 We only ever _add_ to the modules selected from the arguments (never checking for `False`...
And in 3.14 it will be included in the standard library 🥳
3.14 has not been released yet AFAIK, so whenever it's stable.