Sebastian Scheinkman comments

Results 287 comments of


                                            Sebastian Scheinkman

Use per node device plugin config hash

question here I never understand why we really need the `dpConfigVersion` can we drop that ?

Use per node device plugin config hash

This PR https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/669 should remove it

Optimize draining logic

should be fixed via https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/555

DNM: Test ext managed with requested vfs less than configured

Hi @mlguerrero12 can we close this one?

Optmize node watcher in daemon

sure we can do it after we merge https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/555

Optmize node watcher in daemon

Hi @alan-kut thanks for the PR! so the idea base on https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/555 is that we are not going to watch the node anymore the daemon will only watch the nodeState...

Optmize node watcher in daemon

Hi @alan-kut can you take a look on the operator now that we remove the nodes update from the config daemon we have it only on the controller

Check status changes for externally managed interface - netdev device type

Hi @mlguerrero12 thanks for the issue! So the idea why we don't want to do it in the sriov-cni is from security point of view. some network drivers like MLX...

Let "depoly-setup.sh" and "undeploy.sh" fail on error

Hi @thom311 can you please do a force push I am not able to trigger the k8s lane for some reason

Let "depoly-setup.sh" and "undeploy.sh" fail on error

all green merging nice work!