sceneview-android icon indicating copy to clipboard operation
sceneview-android copied to clipboard

PlaneRenderer - Move to Filament mesh builder

Open ThomasGorisse opened this issue 3 years ago • 3 comments

Would you mind doing the move from RenderableDefinittion to Filament direct mesh creation?

We just need to make sure that we aren't missing any important features that Sceneform provided for mesh creation. I actually only used the direct Filament approach.

Originally posted by @grassydragon in https://github.com/SceneView/sceneview-android/issues/39#issuecomment-1066126542

ThomasGorisse avatar Mar 14 '22 19:03 ThomasGorisse

The actual RenderableDefinition is done mostly here: https://github.com/SceneView/sceneview-android/blob/07de18a375cb0c44ceff16e484c889e13cd4cf6c/sceneview/src/main/java/com/google/ar/sceneform/rendering/RenderableDefinition.java#L127 It just use the RenderableDefinition params to move them to Filament IndexBuffer.Builder() and VertexBuffer.Builder() 95% of this nightmare code is for sfb. We just have to delete everything and make sure to only keep the 5% of code we really need.

ThomasGorisse avatar Mar 15 '22 15:03 ThomasGorisse

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 18 '22 05:06 github-actions[bot]

I'll continue working on it after we resolve issues with Filament picking.

grassydragon avatar Jun 18 '22 06:06 grassydragon

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 17 '22 05:09 github-actions[bot]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

github-actions[bot] avatar Sep 24 '22 05:09 github-actions[bot]