sceneview-android icon indicating copy to clipboard operation
sceneview-android copied to clipboard

Users are directed to the play store to install AR Core on unsupported devices

Open kmayoral opened this issue 2 years ago • 3 comments

The library currently does not handle the case where it might have been included in an ARCore optional application. When the ArSceneView is initialized, the check to see if we should install ARCore does not account for unsupported devices and can result in users on unsupported devices being redirected to the play store listing for the ARCore library which they would be unable to install due to it not being compatible with their device.

Instead, the library should allow implementors to get notified of the unsupported device state so the application can react appropriately.

An attempt to address this can be found in https://github.com/SceneView/sceneview-android/pull/322

Thanks for the great library!!

kmayoral avatar Sep 19 '23 19:09 kmayoral

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 19 '23 05:12 github-actions[bot]

This still requires review of the associated PR.

kmayoral avatar Dec 19 '23 16:12 kmayoral

Just wanted to bump this issue and see if there might be additional context that might be required from my end to move this forward? I see that my PR was closed as stale but it's been working as a solution on our end for the last few months. Thanks!

kmayoral avatar Jan 29 '24 17:01 kmayoral

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 29 '24 05:04 github-actions[bot]

The fix has been merged in, thank you!

kmayoral avatar Apr 29 '24 15:04 kmayoral