sceneview-android icon indicating copy to clipboard operation
sceneview-android copied to clipboard

Fix crash on model destroy by lifecycle

Open aleyooop opened this issue 3 years ago • 3 comments

Fix for #145

aleyooop avatar Sep 11 '22 03:09 aleyooop

Are we expecting to have this in the next release? And if so when is the next release?

pecapela avatar Sep 13 '22 11:09 pecapela

Hi! Thank you for the pull request!

Are we expecting to have this in the next release?

There are plans to move away from lifecycle events to manual management of Filament entities so this shouldn't be a problem in the new version.

And if so when is the next release?

I'm sorry but I can't give an estimate since, while we are getting close to the desired vision of the framework, this work is done in free time. However, we'll be absolutely happy when the project becomes widely supported by the community and has regular releases.

grassydragon avatar Sep 13 '22 20:09 grassydragon

@grassydragon Thanks for the response. In the mean while I found a work around. When you start the models like ArModelNode, just put the lifecycle as null and should not crash.

pecapela avatar Sep 14 '22 13:09 pecapela

Hello pecapela can you please add the version should we put inside gradle implemetation to fix the issue

gabrielazwaat avatar Oct 21 '22 11:10 gabrielazwaat

put the lifecycle as null and should not crash

For what it's worth, this doesn't seem to be working for me.

can you please add the version should we put inside gradle implemetation to fix the issue

This isn't an issue with the previous release, 0.7.0. It may be worth considering using the previous release for the time being.

TheDukeofErl avatar Oct 26 '22 18:10 TheDukeofErl

Hello, same thing happens for me. I rollback to 0.8.0 until this fix is merge

AMarquis1 avatar Dec 01 '22 00:12 AMarquis1

Are there any news about this crash? It's the same issue we see in : https://github.com/SceneView/sceneview-android/issues/176

ghost avatar Jan 03 '23 09:01 ghost

Really hope this could be merged ASAP! I was trying to downgrade the version to 0.8.0, however, it uses ARCore 1.3.2 which uses the older ARCore API which is not expected in my project.

sirily11 avatar Jan 16 '23 15:01 sirily11

Fixed in main by completely removing lifecycle

ThomasGorisse avatar Apr 01 '23 18:04 ThomasGorisse