sceneview-android icon indicating copy to clipboard operation
sceneview-android copied to clipboard

Fix crash on rendered frame copy used by SceneView recorder

Open aleyooop opened this issue 3 years ago • 1 comments

In current implementation SurfaceCopier makes copy using SceneLifecycleObserver.onFrame(), which is wrong and causing instant crash.

Considering Filament documentation copyFrame() should be called after a frame is rendered using render but before endFrame is called.

aleyooop avatar Sep 11 '22 03:09 aleyooop

Hi! Thank you for the pull request! We'll take this into consideration after the big changes for the version 1.0.0 are merged by Thomas.

grassydragon avatar Sep 13 '22 20:09 grassydragon