sceneform-android icon indicating copy to clipboard operation
sceneform-android copied to clipboard

About rotation order

Open canlang opened this issue 2 years ago • 3 comments

https://github.com/SceneView/sceneform-android/blob/ba2c818151b91296f048711f494e1acc239ff809/core/src/main/java/com/google/ar/sceneform/math/Quaternion.java#L388

Hello! The document said the order of Euler rotation is ZYX, but it seemed like the rotation order is applied with ZXY. I think the code is rotating Z axis quaternion first, then rotating X axis quaternion, and then Y. Am I wrong? I appreciate your help

canlang avatar Aug 01 '22 06:08 canlang

Hi! I haven't tested it but looking at the multiply method documentation it seems that the order is ZXY: https://github.com/SceneView/sceneform-android/blob/ba2c818151b91296f048711f494e1acc239ff809/core/src/main/java/com/google/ar/sceneform/math/Quaternion.java#L233

grassydragon avatar Aug 01 '22 07:08 grassydragon

So yes, you are probably right.

grassydragon avatar Aug 01 '22 07:08 grassydragon

Thanks for your check!

canlang avatar Aug 01 '22 10:08 canlang

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 06 '23 05:08 github-actions[bot]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

github-actions[bot] avatar Aug 14 '23 05:08 github-actions[bot]