datavault4dbt icon indicating copy to clipboard operation
datavault4dbt copied to clipboard

Mssql

Open cmettler opened this issue 1 year ago • 1 comments

I have continued to make adjustments to the previous sqlserver branch. Mainly, the 'all in' conditions were changed to left outer joins, as 'not in' does not perform very well on SQL Server. Additionally, I joined the ghost record to the ref_hub in the reference table in case some ref_sat entries get deleted. I added a local variable, 'convert_to_hex_style', in the hash_standardization to determine whether '0x' should be part of the string hashkey or not, as I did not know how this was handled in the other implementations. Currently i have only checked this implementation with an sql server adjusted datavault4dbt-snowflake-demo with full+incremental run and md5 with char(32) and binary(16) data types

cmettler avatar Jul 20 '23 10:07 cmettler

Hi @cmettler, and thanks for this Pull Request!

We will review it as soon as our capacities allow it. Thanks for the contribution!

tkirschke avatar Jul 25 '23 06:07 tkirschke