amazon-advertising-api-sdk icon indicating copy to clipboard operation
amazon-advertising-api-sdk copied to clipboard

fix: convert number IDs to BigInt

Open moltar opened this issue 2 years ago • 2 comments

Convert all number identifiers to BigInt.

Closes: #975

moltar avatar Aug 05 '22 15:08 moltar

@moltar we'll have to cover all the ids right? keywordId, adgroupId etc. Also while sending a request to amazon we can send them as a string (but not sure if all the APIs accept them as String).

NishealJ avatar Aug 07 '22 08:08 NishealJ

Ya that's the hardest part is to feed them ints back. Not sure if the api will accept strings. Need to experiment. However, it should be still possible to use some custom serialization method to convert stringified ints to proper ints. Even if it means just using a regex to strip off " from string json.

moltar avatar Aug 07 '22 11:08 moltar