Converter icon indicating copy to clipboard operation
Converter copied to clipboard

Unexpected mod naming for antd

Open steinybot opened this issue 3 years ago • 1 comments

Antd 4.22.3 has lib/pagination/Select.d.ts and lib/select/index.d.ts.

The former is being converted to typings.antd.selectMod and the later typings.antd.libSelectMod.

steinybot avatar Aug 03 '22 23:08 steinybot

This whole module name shortening scheme is impossible to get right, unfortunately. I kind of regret doing it, even if the results in 99% of the cases look better. The biggest problem is that you can't guess scala module name from js import.

The problem here is that pagination sorts before select, and also in part that lib doesn't mean anything. I won't be able to fix this without breaking a whole lot of imports, and I think if we choose to do that in the future it should be to revert back to a guessable but longer scheme.

oyvindberg avatar Aug 08 '22 19:08 oyvindberg

Wow nice work on this! Thanks for all your work on ST, it's great.

steinybot avatar Oct 18 '22 09:10 steinybot