Converter icon indicating copy to clipboard operation
Converter copied to clipboard

Support Material-UI 4

Open lavrov opened this issue 5 years ago • 8 comments

I tried to generate typing for my project where I use material-ui components. I found out that the converter only supports version 3.9.3 and not 4 series. If I try to convert @material-ui/[email protected] I get components without props and with the comment like:

The props of this component has an unsupported shape. You can use `set` manually to use it, but with no compiler support ...

lavrov avatar Oct 27 '20 16:10 lavrov

I would be happy to help with this myself. Any pointers where I'd better start digging at?

lavrov avatar Oct 27 '20 16:10 lavrov

This is #125 . There is a bit of info in #204 as well. https://blog.andrewbran.ch/polymorphic-react-components/ is a good read which explains the design space.

The tldr is that I know how to fix it, but I don't have the time to implement it for quite a while still, unfortunately.

oyvindberg avatar Oct 27 '20 18:10 oyvindberg

Hi. Is there any chance of mui4 getting support any time soon or should i stick to hand-writing the wrappers? Thanks :)

tomasherman avatar Jul 17 '21 15:07 tomasherman

I remember that https://github.com/nafg/scalajs-facades has some facades for MaterialUI 4, you could likely start taking those.

AlexITC avatar Jul 17 '21 15:07 AlexITC

Hi there! I can't commit the time to implement this in the short term unfortunately

oyvindberg avatar Jul 17 '21 16:07 oyvindberg

No worries, just checking 🙂

tomasherman avatar Jul 17 '21 18:07 tomasherman

https://gitter.im/ScalablyTyped/community?at=61ac719942fc2863b243213d

3xau1o avatar Dec 21 '21 16:12 3xau1o

It is worth linking https://github.com/oyvindberg/st-material-ui

AlexITC avatar Jul 22 '22 17:07 AlexITC