reactive-rabbit icon indicating copy to clipboard operation
reactive-rabbit copied to clipboard

Don't close subscriber if channel is recoverable.

Open mkiedys opened this issue 7 years ago • 4 comments

mkiedys avatar Jun 06 '17 14:06 mkiedys

/cc @guizmaii @yspotts

Rebased. Can you guys verify if this works? I'll do some more testing tomorrow.

mkiedys avatar Jun 06 '17 14:06 mkiedys

/cc @guizmaii @yspotts

Rebased. Can you guys verify if this works? I'll do some more testing tomorrow. It also fails to compile in Scala 2.12. Should be easy to fix.

mkiedys avatar Jun 06 '17 14:06 mkiedys

@mkiedys thanks so much for the quick response!

I have tested this locally and it does in fact address the issue. We are hoping to push to production later today or tomorrow and I'll be able to confirm at that point.

Again, thanks for the great library!

yspotts avatar Jun 06 '17 16:06 yspotts

@mkiedys I can confirm it has fixed our issue. We have a brief connection drop every night, and the released version of reactive-rabbit causes our app to discontinue handling messages. This PR enables our app to continue handling messages after the dropped connection. So +1 for merging this PR.

yspotts avatar Jun 09 '17 12:06 yspotts