panopticon-tui icon indicating copy to clipboard operation
panopticon-tui copied to clipboard

Published 20 hours ago • verified publisher icon ScalaConsultants

[WIP] String copies refactor

Open mtsokol opened this issue 4 years ago • 2 comments

Hi! While learning I'm trying to address #4. Here I think we avoid few copies, I only looked at replace_fiber_dump and I plan to look at tree_list_widget tomorrow. I still don't get the exact difference in to_owned for our case.

mtsokol avatar Sep 10 '20 15:09 mtsokol

Hey @mtsokol ! Great that you're working on this one. I'll be back on Monday to maybe look closer

vpavkin avatar Sep 10 '20 18:09 vpavkin

While getting acquainted with code I changed minor borrow-related bits to avoid more copying - thought they got corrected but might be wrong.

mtsokol avatar Sep 17 '20 12:09 mtsokol