Saurav Maheshkar

Results 123 comments of Saurav Maheshkar
trafficstars

Seems like a simple extension of https://github.com/google-deepmind/optax/blob/841be5a860bdf271c0b4ee4b757710bd9497537d/optax/contrib/sam.py#L63-L80 @mtthss can I take this up ?

Thank you @gsaltintas for the help. @JoanaMarieL I'm able to get all of my written reports using the above snippet. However it seems like each report is a instance of...

> Hi @SauravMaheshkar , since we have not heard back from you we are going to close this request. If you would like to re-open the conversation, please let us...

Hey @Devparihar5, we've started an internal chat discussing various options for approaching this. We will update you on the issue once we've reached an agreement.

There should be no difference in where the output file is generated. It's just a simple change of where coverage is configured.

We have another contributor suggesting the same (#1690). Once we merge that PR, you could add translations for other languages.

> Hey @SauravMaheshkar > > Thanks for the PR! > > I have one question, why move to pyproject.toml? what are the benefits? `pyproject.toml` is the new standard for packaging...

> Perfect, thanks @SauravMaheshkar! Let me research, test it out and give it some thought :) PS: Both flax https://github.com/google/flax and PyTorch Geometric https://github.com/pyg-team/pytorch_geometric use a `pyproject.toml` based builds