PIDKiln icon indicating copy to clipboard operation
PIDKiln copied to clipboard

Published 20 hours ago • verified publisher icon Saur0o0n

Unnecessary `/PIDKiln_vars.json` request

Open vitoyucepi opened this issue 3 years ago • 1 comments

Summary

Web application executes additional request every 5 seconds. This is caused by https://github.com/Saur0o0n/PIDKiln/blob/87db341e9dfde9f5992bd66f55080c5b18152272/data/js/json.js#L64

Actual behavior

  1. document.ready event https://github.com/Saur0o0n/PIDKiln/blob/87db341e9dfde9f5992bd66f55080c5b18152272/data/js/json.js#L61
  2. executeQuery function https://github.com/Saur0o0n/PIDKiln/blob/87db341e9dfde9f5992bd66f55080c5b18152272/data/js/json.js#L45
  3. $.ajax request https://github.com/Saur0o0n/PIDKiln/blob/87db341e9dfde9f5992bd66f55080c5b18152272/data/js/json.js#L46-L49
  4. setTimeout https://github.com/Saur0o0n/PIDKiln/blob/87db341e9dfde9f5992bd66f55080c5b18152272/data/js/json.js#L57
  5. another setTimeout https://github.com/Saur0o0n/PIDKiln/blob/87db341e9dfde9f5992bd66f55080c5b18152272/data/js/json.js#L64
  6. Every 5 seconds executeQuery runs two times.

Expected behavior

Only one request should be fired every 5 seconds.

vitoyucepi avatar Jan 30 '22 15:01 vitoyucepi

Hmm I'm vaguely remember I had a reason for that - but perhaps debugging only. I'll take a look.

Saur0o0n avatar Jan 30 '22 17:01 Saur0o0n