proxmox-nixos icon indicating copy to clipboard operation
proxmox-nixos copied to clipboard

Add option to declaratively configure visible bridges

Open xddxdd opened this issue 1 year ago • 3 comments

Add an option to declaratively set the list of bridges visible in Proxmox web interface, so users do not have to manually add the bridge on web interface.

This also helps if /etc/network/interfaces is not persisted across reboots, such as in an impermanence situation.

xddxdd avatar Sep 15 '24 06:09 xddxdd

Sorry for taking a long time to process this PR, I was a bit burried under other things. I am not sure about this one. I think that's kind of a bandage here and that we should make proxmox able to detect bridges like it is able to detect interfaces, if possible.

JulienMalka avatar Nov 19 '24 23:11 JulienMalka

The problem is that NixOS's networking setup (custom scripts or systemd-networkd) is significantly different from Debian (ifupdown), and making Proxmox load our networking config might require a lot of changes to Proxmox code.

While this PR is just a workaround, it works well (at least for me), and is simple enough so that we can easily remove it if Proxmox provided a proper solution.

xddxdd avatar Nov 20 '24 06:11 xddxdd

Reviewing this, but from what I can see, it's a good interim solution. Ideally we'd want Proxmox upstream to make their networking logic more modular and customisable, but this is out of our control.

My personal vote is for a merge. A note to the module for future maintainers to add an assertion warning would be useful when/if we come to remove the module, so that we can warn users.

shymega avatar May 09 '25 20:05 shymega

While I was initially of the mind of finding a more clean solution to this problem, given that I did not have the time to tackle this for now I'm okay with this middle ground solution for the time being.

JulienMalka avatar Jun 08 '25 12:06 JulienMalka